Repository navigation
fix: Restart the stream when a delete event has a version that is not an integer - #585
Merged
Merged
Conversation
… an integer A delete whose version was a string was stored as a deleted item with that version, and the stream stayed open. A later patch for that key then failed when the store compared versions. Generated-by: termag
keelerm84
approved these changes
Nov 17, 2026
There was a problem hiding this comment.
Risk: low.
Automated risk review (dry run): Low
This PR would be automatically approved.
Why: The change is a two-line integer-version check on stream delete events in streaming.py and async_streaming.py, with new sync and async unit tests covering the restart path.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
kinyoklion
added a commit
to launchdarkly/sdk-test-harness
that referenced
this pull request
Nov 17, 2026
…647) <!-- TERMAG_PR_BODY_BEGIN --> The delete payload in the `well-formed JSON not matching schema` tests was missing its closing brace, so the delete case repeated the malformed-JSON case. It now sends a well-formed delete whose version is a string. Python (sync and async), Ruby and Erlang apply that delete instead of restarting the stream, so they fail the case until their fixes merge: launchdarkly/python-server-sdk#585, launchdarkly/ruby-server-sdk#501 and launchdarkly/erlang-server-sdk#213. Merge this after those. The v3 copy of this test comes with #568, which has the same fix. Testing: on the v2 `streaming/validation` tests against 14 server-side test services here, only Python (sync and async), Ruby and Erlang change. Each fails the delete case without its fix and passes with it. <!-- TERMAG_PR_BODY_END --> <!-- termag: box=i-099691946751009d8 project=appease-ai-feverish-2 --> <sub>Opened from termag</sub> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > Fixes the **delete** subtest under `drop and reconnect if stream event has well-formed JSON not matching schema` in `sdktests/server_side_stream_validation.go`. > > The payload was missing its closing `}`, so it duplicated the malformed-JSON behavior. It now sends valid JSON `{"path":"/flags/x","version":"no"}`—schema-invalid because `version` is a string—so the harness asserts drop-and-reconnect on schema mismatch, not on parse failure. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 295f67a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


A stream
deletewhoseversionwas a string was stored as a deleted item with that version, and the stream stayed open. A later patch for that key then failed when the store compared versions. The streaming data source, sync and async, now treats a delete without an integer version as invalid data and restarts the stream, as the other server SDKs do.Testing: new sync and async unit tests fail before this change and pass after it. On the v2 contract-test suite with the corrected schema-mismatch delete test in sdk-test-harness, the delete case fails before this change and passes after it, for the sync and async services, and no other result changes. The v3 suite gives the same results as before.
SDK-3446
Opened from termag
Note
Overview
Streaming delete events with a non-integer
version(e.g. a string) are now rejected in both sync and async processors. Before processing, the SDK checks thatversionis anintand not abool; otherwise it raisesValueError, which triggers the existing interrupt-and-reconnect path instead of applying a bad delete to the feature store.That behavior aligns with other LaunchDarkly server SDKs and avoids corrupt store state that could break later patch version checks. Unit tests were added for sync and async streaming to assert the stream is dropped and re-established when delete
versionis invalid.Reviewed by Cursor Bugbot for commit be4282e. Bugbot is set up for automated code reviews on this repo. Configure here.