Skip to content

max_connections does nothing #386

Closed

Description

@pranjalv123

Describe the bug
max_connections in new_feature_store and new_big_segment_store in ldclient/integrations/__init__.py is unused. This means you would have to pass max_connections inside of redis_opts if you want to limit the max connections.

I believe DEFAULT_MAX_CONNECTIONS is also unused, so the number of redis connections is the redis ConnectionPool default of 2**31.

Expected behavior

I would expect this to limit the number of maximum connections; however, this may be a dangerous change to make as users are probably relying on the unbounded maximum connection behavior.

SDK version

This is present in the latest release on github (9.13.1).

Language version, developer tools
Python

Activity

  1. keelerm84 commented on Dec 4, 2025

    @keelerm84
    Member

    Thank you for raising this issue @pranjalv123.

    Looking at the history of this repository, this parameter was originally deprecated and scheduled for removal in the v8 release. While the implementation and documentation were updated, the commit at the time failed to actually remove it from the method signature. 🤦🏼 I suspect some bad merge conflict where this went unnoticed.

    I will work on making an update to address this issue, and will notify you here when I'm done.

  2. added a commit that references this issue on Dec 4, 2025
    4e767c5
  3. added a commit that references this issue on Dec 4, 2025
  4. added a commit that references this issue on Feb 4, 2026
    e6395fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions