Skip to content

urllib3 < 1.26 not supported #270

Closed

Description

@claudio-cantalupo-ca

Is this a support request?
No

Describe the bug
The minimum requirement specified in pyproject.toml for urllib3 is not correct: urllib3 = ">=1.22.0" it should be urllib3 = ">=1.26.0"

Tried with urllib3 = 1.25.11 and the client initialization continuosly logs this warning:
Unexpected error on stream connection: __init__() got an unexpected keyword argument 'other', will retry

This should be an error by the way because the client will never be able to connect, it just infinitely pollutes the logs.

To reproduce
Put these lines in a requirements.txt and install them in a new venv:

launchdarkly-server-sdk==9.2.0
urllib3==1.25.11

Just init a new client as explained in the LD official doc.

SDK version
v9.2.0 (python 3.9.18)

Activity

  1. keelerm84 commented on Feb 29, 2024

    @keelerm84
    Member

    Thank you for reporting this issue! I will let you know once we have a fix released for the SDK as well as the event source.

  2. added 2 commits that reference this issue on Mar 1, 2024
    ffeded9
    bffe2bb
  3. keelerm84 commented on Mar 1, 2024

    @keelerm84
    Member

    Fixed in v9.2.1.

  4. claudio-cantalupo-ca commented on Mar 4, 2024

    @claudio-cantalupo-ca
    Author

    Thanks for the quick fix!

    Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions