Repository navigation
feat: adopt the event-delivery cooldown from java-sdk-internal - #257
Merged
Merged
Conversation
… (SDK-3375) Picks up the internal events module release in which an unexpected delivery failure opens a bounded, self-recovering cooldown window instead of permanently disabling event delivery. The public EventSender.Result.STOP javadoc now describes the cooldown contract instead of a permanent stop; the enum itself is unchanged, so custom senders compile and run unmodified. The internal wrapper moves off the deprecated internal Result constructor onto the new factories, with new unit coverage for all three mappings and their routing. The contract test service advertises event-delivery-cooldown, which activates the delivery cooldown tests; the 413 variant is suppressed in both suppression files with an in-file rationale, since the shared HTTP classifier still treats a 413 as an unexpected failure rather than a locally unrecoverable one, which is a pre-existing gap tracked separately.
The 413 carve-out fix ships in java-sdk-internal (SDK-3513), so the "events/delivery cooldown/413 is dropped without disabling delivery" test now passes and no longer needs suppressing. Removed from both suppression files; the v2 file returns to empty.
1 of 3 tasks
kinyoklion
added a commit
that referenced
this pull request
Nov 19, 2026
**Requirements** - [ ] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [ ] I have validated my changes against all supported platform versions **Related issues** - #261: the selectorless FDv2 fix in the shared internal module, released in 1.13.0 - launchdarkly/sdk-test-harness#600: contract tests for FDv2 payloads without a selector **Describe the solution you've provided** Bumps `launchdarklyJavaSdkInternal` in `lib/sdk/server/build.gradle` from 1.12.2 to 1.13.0. With 1.12.2, a full transfer with an empty `state` produced a non-empty selector, so the server SDK sent `basis` on its next request. **Describe alternatives you've considered** #257 also bumps to 1.13.0, but its cooldown changes will ship in a later internal version. **Additional context** Local results on Java 8: - `./gradlew test` in `lib/sdk/server`: 1987 tests, 0 failures. - sdk-test-harness#600, `streaming/fdv2/payloads without a selector`: 5/5 pass. 3 of the 5 fail on main. - Full v3 contract suite with the CI suppression file and persistence tests: 6311 ran, all passed. Link to Devin session: https://app.devin.ai/sessions/fa07e76e6e3346c9b26f2eae4ff6694b Open in Devin Desktop: https://app.devin.ai/desktop/session/fa07e76e6e3346c9b26f2eae4ff6694b?variant=devin Requested by: @kinyoklion <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > Bumps **`launchdarklyJavaSdkInternal`** in `lib/sdk/server/build.gradle` from **1.12.2** to **1.13.0**, pulling in the shared internal fix for **selectorless FDv2** payloads (issue #261). > > Previously, a full transfer with an empty `state` could still yield a non-empty selector, so the server SDK incorrectly sent **`basis`** on the following streaming request. Contract tests for payloads without a selector are expected to pass after this upgrade. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 703704e. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ver-257 # Conflicts: # lib/sdk/server/build.gradle
There was a problem hiding this comment.
Risk: medium.
Automated risk review (dry run): Medium
This PR would not be automatically approved. Human approval required.
Why: The server SDK now maps EventSender STOP to unexpectedFailure (bounded cooldown instead of a permanent stop) and bumps launchdarkly-java-sdk-internal to 1.14.0, which is a production event-delivery behavior change. Unit tests cover the wrapper mapping, but that is still above the Low-only auto-approve threshold.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
kinyoklion
approved these changes
Nov 20, 2026
tanderson-ld
pushed a commit
that referenced
this pull request
Nov 20, 2026
🤖 I have created a release *beep* *boop* --- ## [7.19.0](launchdarkly-java-server-sdk-7.18.2...launchdarkly-java-server-sdk-7.19.0) (2026-11-20) ### Features * adopt the event-delivery cooldown from java-sdk-internal ([#257](#257)) ([e21c23b](e21c23b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > Bumps the **Java server SDK** from **7.18.2** to **7.19.0** across Release Please manifest, `gradle.properties`, `Version.SDK_VERSION`, and **CHANGELOG**. > > The **7.19.0** notes document a **feature** release: the server SDK now **adopts event-delivery cooldown behavior from `java-sdk-internal`** ([#257](#)), so failed analytics delivery uses a **bounded cooldown** instead of staying disabled permanently until restart. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c9f5dc0. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What
Adopts the event-delivery cooldown (EVTPROC Section 1.8, launchdarkly/sdk-specs#278) in the server SDK by picking up launchdarkly-java-sdk-internal 1.14.0, which replaces the permanent disable-on-unexpected-delivery-failure with bounded, self-recovering cooldown windows (see the internal module PR #256 for the behavior itself).
launchdarklyJavaSdkInternalto 1.14.0.EventSenderWrapperoff the deprecated internalResultconstructor onto the new factories (SUCCESStosuccess(null),FAILUREtofailure(),STOPtounexpectedFailure()), and adds the previously missing unit coverage for that mapping. This is the one behavioral change in the server module: a customEventSenderreturningSTOPnow drives a bounded cooldown rather than a permanent stop.subsystems.EventSender.Result.STOPenum and its javadoc unchanged.STOPis still the public signal for an unexpected delivery failure; the cooldown is the SDK's internal response to it, documented in the internal module and the release notes rather than in this interface doc.event-delivery-cooldowncapability in the contract test service, activating theevents/delivery cooldowntests.Dependencies (both gates cleared)
Verification
Built and tested against the released 1.14.0: the server module compiles, checkstyle is clean, and the
EventSenderWrappermapping tests pass (STOP to unexpectedFailure, FAILURE to ordinary failure, SUCCESS to delivered, and the diagnostic path using the same mapping). The fullevents/contract suite runs in CI against the released harness.Release notes
EventSenderreturningSTOPnow causes the same bounded cooldown.Note
Overview
This PR adopts event-delivery cooldown in the Java server SDK by upgrading
launchdarkly-java-sdk-internalto 1.14.0. Unexpected delivery failures (e.g. customEventSenderreturningSTOP) now trigger bounded backoff and recovery instead of permanently shutting down event delivery.The server’s
EventSenderWrapperis updated to use the internalResultfactory APIs (failure(),unexpectedFailure(),success(null)) soSTOPmaps to unexpected failure and plugs into the new cooldown behavior in the internal event processor.The contract test service advertises
event-delivery-cooldown, enabling harness cooldown tests. Unit tests cover success, ordinary failure, andSTOPmapping for both analytics and diagnostic sends.Reviewed by Cursor Bugbot for commit 2598dcf. Bugbot is set up for automated code reviews on this repo. Configure here.