Repository navigation
fix: Update launchdarkly-java-sdk-internal to 1.13.0 - #272
Merged
Merged
Conversation
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
kinyoklion
marked this pull request as ready for review
November 19, 2026 16:39
There was a problem hiding this comment.
Risk: low.
Automated risk review (dry run): Low
This PR would be automatically approved.
Why: One-line bump of launchdarklyJavaSdkInternal from 1.12.2 to 1.13.0 in lib/sdk/server/build.gradle; Cursor Bugbot completed with no findings.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
tanderson-ld
approved these changes
Nov 19, 2026
kinyoklion
pushed a commit
that referenced
this pull request
Nov 20, 2026
🤖 I have created a release *beep* *boop* --- ## [7.18.2](launchdarkly-java-server-sdk-7.18.1...launchdarkly-java-server-sdk-7.18.2) (2026-11-20) ### Bug Fixes * Clear empty FDv2 selectors in shared protocol handling ([#261](#261)) ([576b081](576b081)) * Prevent flags in a persistent store from becoming available to mobile keys ([#275](#275)) ([32c8676](32c8676)) * Treat a null optional property in flag data as omitted ([#268](#268)) ([3af465d](3af465d)) * Update launchdarkly-java-sdk-internal to 1.13.0 ([#272](#272)) ([9cc5885](9cc5885)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > This **release PR** bumps the LaunchDarkly Java server SDK from **7.18.1** to **7.18.2** across Release Please metadata (`gradle.properties`, `Version.SDK_VERSION`, and `.release-please-manifest.json`). > > The new **CHANGELOG** section records the fixes shipped in this patch: clearing empty FDv2 selectors in shared protocol handling, blocking persistent-store flags from being exposed to mobile keys, treating null optional flag properties as omitted, and updating `launchdarkly-java-sdk-internal` to 1.13.0. Those behavioral changes are not part of this diff—only the version and release notes are updated here. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 9087581. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Requirements
Related issues
Describe the solution you've provided
Bumps
launchdarklyJavaSdkInternalinlib/sdk/server/build.gradlefrom 1.12.2 to 1.13.0. With 1.12.2, a full transfer with an emptystateproduced a non-empty selector, so the server SDK sentbasison its next request.Describe alternatives you've considered
#257 also bumps to 1.13.0, but its cooldown changes will ship in a later internal version.
Additional context
Local results on Java 8:
./gradlew testinlib/sdk/server: 1987 tests, 0 failures.streaming/fdv2/payloads without a selector: 5/5 pass. 3 of the 5 fail on main.Link to Devin session: https://app.devin.ai/sessions/fa07e76e6e3346c9b26f2eae4ff6694b
Open in Devin Desktop: https://app.devin.ai/desktop/session/fa07e76e6e3346c9b26f2eae4ff6694b?variant=devin
Requested by: @kinyoklion
Note
Overview
Bumps
launchdarklyJavaSdkInternalinlib/sdk/server/build.gradlefrom 1.12.2 to 1.13.0, pulling in the shared internal fix for selectorless FDv2 payloads (issue #261).Previously, a full transfer with an empty
statecould still yield a non-empty selector, so the server SDK incorrectly sentbasison the following streaming request. Contract tests for payloads without a selector are expected to pass after this upgrade.Reviewed by Cursor Bugbot for commit 703704e. Bugbot is set up for automated code reviews on this repo. Configure here.