Repository navigation
Conversation
Generated-by: termag
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f6d53b6. Configure here.
| - uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756 # v1.13.0 | ||
| - uses: TheMrMilchmann/setup-msvc-dev@368ef7d1ee4d1171b31d4a7f67f4d954f903f5a9 # v4.1.0 | ||
| with: | ||
| arch: x64 |
There was a problem hiding this comment.
MSVC setup runs on non-Windows jobs
High Severity
The hello-apps smoketest runs TheMrMilchmann/setup-msvc-dev on the full OS matrix, including Ubuntu and macOS. The previous ilammy/msvc-dev-cmd action no-ops off Windows, but this replacement is a Windows-only Visual Studio setup and does not document that skip. Those jobs can fail when the action cannot find vswhere or vcvarsall.
Reviewed by Cursor Bugbot for commit f6d53b6. Configure here.
There was a problem hiding this comment.
Risk: medium.
Automated risk review (dry run): Medium
This PR would not be automatically approved. Human approval required.
Why: This changes CI workflow definitions in .github/workflows/*.yml and the Windows MSVC setup in .github/actions/sdk-release/action.yml, which is never Low. Cursor Bugbot also left an unresolved high-severity finding that hello-apps.yml runs the Windows-only setup-msvc-dev action on the full OS matrix.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver




Summary
ilammy/msvc-dev-cmdruns on Node.js 20 and has had no release since January 2024. The upstream pull requests that move it to Node.js 24 are still open. This change replaces all 11 uses withTheMrMilchmann/setup-msvc-devv4.1.0, which runs on Node.js 24. Each use setsarch: x64, which is the default formsvc-dev-cmd.Opened from termag
Note
Overview
Swaps the Windows MSVC setup action across 11 GitHub Actions steps (release composite action plus client, server, cmake, hello-apps, and extension workflows) from
ilammy/msvc-dev-cmdtoTheMrMilchmann/setup-msvc-devv4.1.0, pinned at commit368ef7d1….Each Windows job now explicitly passes
arch: x64, matching the prior default behavior. The goal is to keep MSVC-based builds working on runners that use Node.js 24, sincemsvc-dev-cmdstill targets Node 20 and is effectively unmaintained.Reviewed by Cursor Bugbot for commit f6d53b6. Bugbot is set up for automated code reviews on this repo. Configure here.