Skip to content

chore: Replace msvc-dev-cmd with setup-msvc-dev for Node.js 24 - #659

Open
keelerm84 wants to merge 1 commit into
mainfrom
mk/SDK-3652/replace-node20-actions
Open

keelerm84 wants to merge 1 commit into
mainfrom
mk/SDK-3652/replace-node20-actions

Conversation

@keelerm84

@keelerm84 keelerm84 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Summary

ilammy/msvc-dev-cmd runs on Node.js 20 and has had no release since January 2024. The upstream pull requests that move it to Node.js 24 are still open. This change replaces all 11 uses with TheMrMilchmann/setup-msvc-dev v4.1.0, which runs on Node.js 24. Each use sets arch: x64, which is the default for msvc-dev-cmd.

Opened from termag


Note

Overview
Swaps the Windows MSVC setup action across 11 GitHub Actions steps (release composite action plus client, server, cmake, hello-apps, and extension workflows) from ilammy/msvc-dev-cmd to TheMrMilchmann/setup-msvc-dev v4.1.0, pinned at commit 368ef7d1….

Each Windows job now explicitly passes arch: x64, matching the prior default behavior. The goal is to keep MSVC-based builds working on runners that use Node.js 24, since msvc-dev-cmd still targets Node 20 and is effectively unmaintained.

Reviewed by Cursor Bugbot for commit f6d53b6. Bugbot is set up for automated code reviews on this repo. Configure here.

@keelerm84
keelerm84 requested a review from a team as a code owner November 20, 2026 16:24

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f6d53b6. Configure here.

- uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756 # v1.13.0
- uses: TheMrMilchmann/setup-msvc-dev@368ef7d1ee4d1171b31d4a7f67f4d954f903f5a9 # v4.1.0
with:
arch: x64

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSVC setup runs on non-Windows jobs

High Severity

The hello-apps smoketest runs TheMrMilchmann/setup-msvc-dev on the full OS matrix, including Ubuntu and macOS. The previous ilammy/msvc-dev-cmd action no-ops off Windows, but this replacement is a Windows-only Visual Studio setup and does not document that skip. Those jobs can fail when the action cannot find vswhere or vcvarsall.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f6d53b6. Configure here.

@cursor cursor Bot added the risk:medium label Nov 20, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium.

Automated risk review (dry run): Medium

This PR would not be automatically approved. Human approval required.

Why: This changes CI workflow definitions in .github/workflows/*.yml and the Windows MSVC setup in .github/actions/sdk-release/action.yml, which is never Low. Cursor Bugbot also left an unresolved high-severity finding that hello-apps.yml runs the Windows-only setup-msvc-dev action on the full OS matrix.

If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.

Open in Web View Automation 

Sent by Cursor Approval Agent: Dry-Run PR Approver

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant