Skip to content

fix: Engage the FDv1 fallback when an FDv2 stream server error has the fallback directive - #658

Draft
kinyoklion wants to merge 1 commit into
mainfrom
rlamb/sdk-3691/fdv2-fallback-on-error
Draft

kinyoklion wants to merge 1 commit into
mainfrom
rlamb/sdk-3691/fdv2-fallback-on-error

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

When the FDv2 stream answered with a server error and X-LD-FD-Fallback: true, the server SDK ignored the directive and kept retrying FDv2. The SSE client retries a 5xx response without reporting an error, so the streaming synchronizer only stored the directive, and the data system never got a result that had it. The synchronizer now reports a 5xx response that has the directive as an interrupted result with the directive, so the data system engages the FDv1 fallback and closes the FDv2 stream. Without a configured FDv1 fallback the data system now stops, so the suppression of "directive without FDv1 fallback configured halts the data system" is removed. The fallback TTL handling does not change.

Testing: new synchronizer tests fail before the change and pass after it. The harness tests "directive on a server error response engages FDv1 fallback" and "directive without FDv1 fallback configured halts the data system" change from fail to pass with the Beast and CURL builds; "returns to FDv2 when the fallback TTL elapses" still fails, as before. The full v2 and v3 contract suites with the Beast and CURL builds show no other change.

SDK-3691

Opened from termag

…e fallback directive

The SSE client retries a server error response and does not report it, so
the FDv2 streaming synchronizer kept the fallback directive of a 5xx
response and the data system never saw it. Report a server error response
that has the directive at once, so that the data system engages the FDv1
fallback, or stops when it has no FDv1 fallback.

The contract test for a directive without an FDv1 fallback passes now, so
remove its suppression.

Generated-by: termag

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant