Skip to content

fix: Ignore a stream delete for an unknown kind of item instead of restarting the stream - #657

Draft
kinyoklion wants to merge 1 commit into
mainfrom
rlamb/sdk-3690/delete-unknown-kind
Draft

kinyoklion wants to merge 1 commit into
mainfrom
rlamb/sdk-3690/delete-unknown-kind

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

The server SDK treated a stream delete event whose path has an unknown kind, for example /cats/Jack, as invalid data. It restarted the stream, so the events after the delete on the same connection were lost. A patch event of an unknown kind is ignored, and a delete event must be the same, because the service can add new kinds of data. The SDK now ignores such a delete and keeps the stream. A delete without a path or a version is still invalid data.

Testing: a new event handler test fails before the change and passes after it. The harness test "delete event with unrecognized path kind" changes from fail to pass with the Beast build; with the CURL build it passed by timing before the change, but the service log showed the stream restart, which no longer occurs. The full v2 and v3 contract suites with the Beast and CURL builds show no other change.

SDK-3690

Opened from termag

…starting the stream

A delete event whose path had an unknown kind was invalid data, so the
SDK restarted the stream and lost the events after it. Ignore it, as for
a patch event of an unknown kind.

Generated-by: termag

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant