Repository navigation
fix: Ignore a stream delete for an unknown kind of item instead of restarting the stream - #657
Draft
kinyoklion wants to merge 1 commit into
Draft
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
…starting the stream A delete event whose path had an unknown kind was invalid data, so the SDK restarted the stream and lost the events after it. Ignore it, as for a patch event of an unknown kind. Generated-by: termag
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server SDK treated a stream
deleteevent whose path has an unknown kind, for example/cats/Jack, as invalid data. It restarted the stream, so the events after the delete on the same connection were lost. Apatchevent of an unknown kind is ignored, and adeleteevent must be the same, because the service can add new kinds of data. The SDK now ignores such a delete and keeps the stream. A delete without a path or a version is still invalid data.Testing: a new event handler test fails before the change and passes after it. The harness test "delete event with unrecognized path kind" changes from fail to pass with the Beast build; with the CURL build it passed by timing before the change, but the service log showed the stream restart, which no longer occurs. The full v2 and v3 contract suites with the Beast and CURL builds show no other change.
SDK-3690
Opened from termag