Skip to content

fix: Evaluate fixed variations of flags and segments that have no salt - #655

Draft
kinyoklion wants to merge 1 commit into
mainfrom
rlamb/sdk-3669/salt-only-for-bucketing
Draft

kinyoklion wants to merge 1 commit into
mainfrom
rlamb/sdk-3669/salt-only-for-bucketing

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

A flag with no salt, or a null salt, returned MALFORMED_FLAG for every rule and fallthrough, even one that serves a fixed variation, and a segment with no salt failed every segment rule. The salt is optional in the data model, and only bucketing uses it. The SDK now checks for the salt only where bucketing needs it: a rollout or experiment without a seed, and a segment rule with a weight. A rollout without a seed and without a salt is still MALFORMED_FLAG, because the default salt for that case is not decided yet.

Testing: new evaluator tests fail before the change and pass after it. In the harness data model tests for minimal and null properties, every fixed-variation case changes from fail to pass with the Beast and CURL builds; "rollout with only variations" still fails, because it needs a salt. The full v2 and v3 contract suites with the Beast build show no other change.

SDK-3669

Opened from termag

A flag without a salt returned MALFORMED_FLAG for every rule and
fallthrough, even one that serves a fixed variation, and a segment without
a salt failed every segment rule. Check for the salt only where bucketing
uses it: a rollout without a seed, and a segment rule with a weight.

Generated-by: termag

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant