Repository navigation
fix: Evaluate fixed variations of flags and segments that have no salt - #655
Draft
kinyoklion wants to merge 1 commit into
Draft
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
A flag without a salt returned MALFORMED_FLAG for every rule and fallthrough, even one that serves a fixed variation, and a segment without a salt failed every segment rule. Check for the salt only where bucketing uses it: a rollout without a seed, and a segment rule with a weight. Generated-by: termag
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A flag with no salt, or a null salt, returned MALFORMED_FLAG for every rule and fallthrough, even one that serves a fixed variation, and a segment with no salt failed every segment rule. The salt is optional in the data model, and only bucketing uses it. The SDK now checks for the salt only where bucketing needs it: a rollout or experiment without a seed, and a segment rule with a weight. A rollout without a seed and without a salt is still MALFORMED_FLAG, because the default salt for that case is not decided yet.
Testing: new evaluator tests fail before the change and pass after it. In the harness data model tests for minimal and null properties, every fixed-variation case changes from fail to pass with the Beast and CURL builds; "rollout with only variations" still fails, because it needs a salt. The full v2 and v3 contract suites with the Beast build show no other change.
SDK-3669
Opened from termag