[MegaRedHand]

🗒️ Description / Motivation

tooling/kurtosis-validator wrapped upstream ethereum-package to bolt one ethlambda validator client (and optionally an ethlambda beacon) onto a finished devnet. Our fork, lambdaclass/ethereum-package@add-ethlambda, now adds ethlambda as a native cl_type and vc_type, so the wrapper is redundant:

• ethlambda participants are ordinary ethereum-package services, so the package's own additional services (assertoor, dora) see them. The wrapper's services were invisible to them.
• The wrapper imported github.com/ethpandaops/ethereum-package unpinned, and its kurtosis.yml still named ethlambda_private.

What Changed

• Deleted tooling/kurtosis-validator/ (main.star, kurtosis.yml, three network_params*.yaml).
• docs/rpc.md: the one reference to it now points at the fork.

Scenario mapping

Wrapper args file	Fork equivalent
network_params.yaml (ethlambda VC on lighthouse BN)	cl_type: lighthouse, vc_type: ethlambda
network_params_ethlambda_beacon.yaml (ethlambda VC on ethlambda beacon)	cl_type: ethlambda (VC defaults to ethlambda)
network_params_lighthouse_vc.yaml (Lighthouse VC + doppelganger on ethlambda beacon)	cl_type: ethlambda, vc_type: lighthouse, vc_extra_params: [--enable-doppelganger-protection] (accepted by the fork's input parser; not run)

The fork refuses cl_type: ethlambda as the first participant unless bootnodoor is enabled, since ethlambda reports no ENR over the Beacon API. See the fork's .github/tests/ethlambda.yaml for a working example.

One note from the deleted yaml comments is not encoded in the fork: lighthouse peers with few validators of their own want --subscribe-all-subnets (cl_extra_params), because ethlambda beacon publishes attestations through gossipsub fanout, which reaches only peers subscribed to the subnet. (The other note, lighthouse's --target-peers=0 pin, no longer applies: ethereum-package adds it only when lighthouse is the sole participant.)

Correctness / Behavior Guarantees

No code or CI change; nothing in the workspace, Makefile or workflows referenced the wrapper.

Tests Added / Run

None: no Rust touched. git grep kurtosis-validator is empty after the change.

Related Issues / PRs

• Related to ci: add a kurtosis + assertoor battery for the beacon node #679 (kurtosis + assertoor battery, which runs on the fork)

[github-actions]

🤖 Kimi Code Review

I'll review this PR which removes the standalone Kurtosis tooling in favor of using a fork of ethereum-package with native ethlambda support.

Overall Assessment

This is a cleanup PR that removes deprecated tooling after migrating to a better-integrated approach. The changes are straightforward deletions with documentation updates. No consensus-critical Rust code is modified.

Detailed Review

1. Documentation Update (docs/rpc.md)

Lines 357-362: The documentation update correctly explains the new architecture. One minor issue:

• Line 361: "every block its validators propose is one this node built" — this phrasing is slightly awkward. Consider: "every block its validators propose is built by this node" for clarity.

2. File Deletions

The following files are removed, all from tooling/kurtosis-validator/:

File	Purpose	Removal Correct?
kurtosis.yml	Package metadata	Yes — no longer a standalone package
main.star	378-line Starlark orchestration	Yes — logic moved to ethereum-package fork
network_params.yaml	Basic devnet config	Yes — now native in fork
network_params_ethlambda_beacon.yaml	Beacon node testing config	Yes — now native in fork
network_params_lighthouse_vc.yaml	Lighthouse VC interop config	Yes — now native in fork

3. Verification of Migration Completeness

The deleted main.star contained several important safety checks that should be preserved in the new ethereum-package fork:

Key safety logic from deleted main.star:

• Lines 54-72: Validator key range validation — ensuring preregistered_validator_count exceeds participant totals to avoid double-signing. Critical for slashing protection. Verify this exists in the fork.

• Lines 74-82: Explicit key index bounds checking (first >= participants_total, last <= genesis_total, first < last). Must be preserved.

• Lines 120-122: Comment warning about slashing protection: "The ethlambda validator client keeps no slashing-protection record, so a key held by it and by any other client would be signed twice every slot." This warning should appear in fork documentation.

• Lines 284-287: eth2-val-tools with --insecure flag for fast KDF in dev environments. Acceptable for testing only; verify this is still marked clearly as insecure.

4. Potential Issues in Deleted Code (for reference in fork)

While deleting, note these patterns for the new implementation:

• Line 290-291: The printf-based validator_definitions.yml generation uses shell-escaped newlines (\\n). The comment explains this is due to Kurtosis mangling newlines — verify if this workaround is still needed in the fork.

• Lines 327-328: Dora restart uses stop_service then start_service. This is a container restart that preserves filesystem state. Ensure the fork's equivalent handles Dora labeling correctly.

• Lines 364-365: geth --override.genesis flag usage. Verify compatibility with current geth versions in the fork.

5. Security Considerations

No direct security issues in this deletion PR, but ensure the fork addresses:

1. Slashing protection: The deleted code explicitly noted ethlambda validator lacks slashing protection. The fork must maintain exclusive key assignment or implement protection.

2. JWT secret handling: The deleted code mounted JWT at /jwt/jwtsecret. Verify path consistency in fork.

3. --insecure KDF flag: Only acceptable in devnets; must not reach production configurations.

6. Suggestions

• Add migration note: Consider a tooling/kurtosis-validator/README.md or tooling/README.md pointing to the new fork location (lambdaclass/ethereum-package, branch add-ethlambda) for users with existing workflows.

• Verify fork branch naming: The docs reference branch add-ethlambda. Ensure this branch remains available or is merged to avoid broken documentation links.

Conclusion

The PR is correct and safe as a cleanup operation. The main risk is migration completeness — ensuring the ethereum-package fork preserves the safety checks and configuration flexibility of the deleted standalone tooling. No blocking issues.

---

Automated review by Kimi (Moonshot AI) · kimi-k2.6 · custom prompt

[github-actions]

🤖 Codex Code Review

Looks good overall. This PR is doc/tooling-only: it updates docs/rpc.md and deletes the local Kurtosis wrapper under tooling/kurtosis-validator, with no consensus, fork-choice, SSZ, signature, or state-transition code changes to review.

• No correctness, security, memory-safety, or performance concerns in Rust code, because no Rust code changes are included.
• docs/rpc.md:357 is internally consistent with the rest of the repo: I found no remaining references to the deleted tooling/kurtosis-validator package, so the doc does not appear to leave stale in-repo pointers behind.
• docs/rpc.md:357 does introduce an external dependency on a fork/branch (lambdaclass/ethereum-package, add-ethlambda). That is fine for documentation, but it is a maintenance risk: if that branch is renamed or removed, this section becomes stale. If you want to harden it, prefer pointing to a tagged release, commit SHA, or a stable README section instead.

No blocking issues from this diff.

---

Automated review by OpenAI Codex · gpt-5.4 · custom prompt

[github-actions]

🤖 Claude Code Review

Review of PR 690: drop the kurtosis-validator wrapper

Verdict: looks good, with one small docs nit. The PR only deletes tooling/kurtosis-validator/ and edits one paragraph in docs/rpc.md. No Rust code is touched, so there are no consensus, crypto or SSZ concerns.

Checks run

• git grep kurtosis over the tree shows no remaining reference to the wrapper path. The other hits are generic mentions of kurtosis-mounted network files (cli.rs, network/dir.rs, test fixtures, README.md), and they are still accurate.
• The old wrapper imported ethpandaops/ethereum-package unpinned and had a stale ethlambda_private name in its kurtosis.yml. Removing it gets rid of that drift.

Notes

1. docs/rpc.md now links to a moving branch (tree/add-ethlambda). If the fork renames or merges that branch, the link breaks. Pinning a tag or commit, or pointing at the fork's README, would be more durable. This is minor.
2. The new docs/rpc.md text says an ethlambda cl_type participant "runs an ethlambda validator client that, by default, talks to this node alone". That matches the PR description but depends on the fork's defaults. I couldn't check it from this repo, so it's worth confirming against the fork.
3. The PR description says the --subscribe-all-subnets guidance from the deleted yaml comments is not encoded anywhere. That is a real operational gotcha. Lighthouse peers with few validators of their own won't receive ethlambda beacon's fanout-published attestations. The note would survive better as a sentence in docs/rpc.md or a devnet doc than only in the PR text. Optional.
4. The third scenario (Lighthouse VC with doppelganger protection on an ethlambda beacon) is marked "accepted by the fork's input parser; not run". The deleted yaml was the only in-repo exercise of /eth/v1/validator/liveness and the sync-duties path against a non-ethlambda VC. Make sure the fork or ci: add a kurtosis + assertoor battery for the beacon node #679's battery covers that scenario, so the coverage isn't lost silently.

---

Automated review by Claude (Anthropic) · sonnet · custom prompt