Repository navigation
test: add tests for the new RPC API routes - #56
Merged
Merged
Conversation
MegaRedHand
force-pushed
the
rpc-api-tests
branch
2 times, most recently
from
January 26, 2026 20:49
655b378 to
4f4f5cb
Compare
MegaRedHand
marked this pull request as ready for review
January 26, 2026 20:49
tcoratger
pushed a commit
to tcoratger/ethlambda
that referenced
this pull request
Oct 30, 2026
…mbdaclass#56) * Pack other nodes' attestations into blocks ethlambda beacon builds, and make packing safe for them. P2P verifies every gossip aggregate on arrival but only forwarded the accepted ones to fork choice, so the pool block production reads held nothing but this node's own votes and aggregates. Validated::forward now also adds each accepted electra aggregate to the pool, where all three of its signatures have just been verified; pooling on arrival means a slot's aggregates are there when the next slot's block is asked for. pack_attestations now requires an attestation's target root to be the proposal state's own block root for that epoch, because an aggregate made on another branch was checked against that branch's committees, and verifies each merged attestation's signature against the proposal state, dropping one that fails and taking the next, instead of relying on produce()'s retry that dropped every attestation. P2P also prunes the pool on its aggregator-subnet sweep, so a pool nothing is inserted into does not keep stale entries. The pack_attestations fixtures now sign with the real committee members and target the state's own block root (the merge test uses 8192 validators, the fewest that give mainnet's preset two committees a slot), and new tests cover a target on another branch, a signature that does not verify, and forward pooling an accepted electra aggregate but not a phase0 or an unaccepted one. docs/rpc.md describes what the pool holds and the new packing checks. * Let the attestation merge test hold on the minimal preset. It asserted exactly two committees a slot for 8192 validators, which is mainnet's count; minimal's smaller committees give four, so Test minimal preset and Beacon spec tests (minimal) failed on it. The test only uses committees 0 and 1, so it now asserts at least two. --------- Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for the new RPC API routes.