Repository navigation
feat: add rest of fork choice metrics - #52
Merged
Merged
Conversation
Add Group 3 metrics from the leanMetrics specification: - lean_attestations_valid_total: Count of valid attestations with source label (block/gossip) - lean_attestations_invalid_total: Count of invalid attestations with source label (block/gossip) - lean_fork_choice_reorgs_total: Count of fork choice reorganizations Attestation counting is added to on_gossip_attestation (gossip source) and on_block (block source). Reorg detection is added to update_head by checking if the new head is not a direct child of the previous head.
tcoratger
pushed a commit
to tcoratger/ethlambda
that referenced
this pull request
Oct 30, 2026
…next slot (lambdaclass#52) lambdaclass#48 left every held block's columns to gossip until the next slot's redrive, because at the tip gossip completes a held block within a fraction of a second and an immediate by-root ask only raced it. A block that is already older than the current slot has no gossip left to wait for: its columns went out long before this node held it. Range-synced catch-up is exactly that case. After a fresh checkpoint sync on a mainnet follower, the 72 blocks from before the restart were each held missing every custody column and each waited out a redrive, so the follower imported about one block per slot and its lag stayed flat for eight minutes. A block held at a slot older than the current one now asks by root at hold time. A block at or ahead of the current slot keeps lambdaclass#48's behavior. The condition is the block's age rather than its source, since age is what decides whether gossip can still deliver the columns. Repeated holds of one block cost nothing extra: the p2p side merges a repeat ask into the lookup already in flight for that root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some more metrics from leanMetrics: