Skip to content

fix: bounce setbacks, sprint, fake lag and the passer - #356

Open
blocksimus wants to merge 8 commits into
lambda-client:1.21.11from
blocksimus:fix/bounce-improvements
Open

blocksimus wants to merge 8 commits into
lambda-client:1.21.11from
blocksimus:fix/bounce-improvements

Conversation

@blocksimus

Copy link
Copy Markdown
Contributor

Description

Been bouncing a lot more on 2b2t... these are some fixes that held up in testing.

Start-flying now looks like pressing jump in the air to open the elytra: jump's let go just before it and pressed again by the next move, which is what Grim's ElytraB checks for.

Sprint - Bounce used to have isSprinting say true while gliding without the speed sprinting adds, so after a landing it walked at walking speed with the flag on and got set back (stuck walking loops). It now really sprints while it glides, starting with start-flying, (also stops when you're too hungry to, which was getting me kicked).

After a setback it keeps hopping through the flag pause, instead of sitting on the ground and losing the glide.

Fake Lag

  • won't hold for more than max hold ticks (new setting, default 10), when stuck against something it held for too long and then sent all at once and got kicked
  • sends a setback's confirm and the move after it straight away, Grim ignore everything else until its confirmed.
  • holds the pongs now, not the pings. Pings were held as they arrived, ahead of a setback still waiting to be handled, so the ping Grim sends after a setback got answered first, and Grim sends the setback again when that happens. Flushing them also answered held pings in reverse order
  • only holds packets sent on the game thread, since keep-alives are answered from the network thread

Obstacle passer - fixed a freeze when you get set back before moving off the start, and it standing still forever when it finished a block beside the line, since Baritone stops a block short of its goal.

Grim's ElytraB wants the jump key released as start-flying goes out
and pressed by the next move, as pressing jump mid-air sends them.
Bounce had isSprinting say true while gliding, without the speed
sprinting adds, so off the glide it walked at walking speed with the
flag on, which Grim set back every move. It now sprints for real,
from start-flying on, while canSprintOrFly allows it.
Bounce stopped jumping in the pause after a setback, so it stayed on
the ground after landing, and the server ended the glide.
Stuck against something, nothing ended a hold: on 2b2t that held
everything back for 13 s, and the server dropped the connection.
The server takes no moves after a setback until its confirm and the
move after it, so holding those had it set Bounce back again.
Keep-alives are answered from the network thread, where Fake Lag held
them in the game thread's queue, and a flush from there threw, losing
the answer and timing the player out.
Pings were held as they arrived, ahead of packets still waiting for
the game thread, so a setback's confirm answered the ping Grim sends
after it, and Grim set back again: 76 of 77 such setbacks on 2b2t.
Flushing them also answered pings held together in reverse order.
Pings are now answered in turn, and Fake Lag holds the pongs instead.
A setback before moving off the start gave the passer no direction to
search along, and it never finished beside the line, as Baritone stops
a block short of its goal and the check wanted the exact block.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant