Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BodyDump omits successfully written response bytes when the underlying writer returns a partial count and an error. The bounded writer returns before recording the prefix, and the unlimited
io.MultiWriterpath stops before copying it to the dump buffer.Use the existing dump writer for both modes and record only the accepted prefix before returning the write error. Preserve the dump limit and report
io.ErrShortWritefor a short write with no error. Six regression cases cover bounded/unlimited dumps and explicit/silent write failures; the original partial-error cases fail before the fix. Full race tests, build, go vet, staticcheck, golint and diff checks pass.