Skip to content

Improved error handling - #17

Merged
cihangir merged 1 commit into
koding:masterfrom
ttjiaa:improved-error-handling
May 18, 2018
Merged

cihangir merged 1 commit into
koding:masterfrom
ttjiaa:improved-error-handling

Conversation

@ttjiaa

@ttjiaa ttjiaa commented Feb 20, 2018

Copy link
Copy Markdown
Contributor

@seriousben

Copy link
Copy Markdown

Thanks @ttjiaa

@dsamarin dsamarin mentioned this pull request Feb 24, 2018

@dsamarin dsamarin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@felipenoris

Copy link
Copy Markdown

Hello, can this be merged?

@cihangir

Copy link
Copy Markdown
Contributor

Thanks for sending the patches to us as well!

@ttjiaa

ttjiaa commented May 12, 2018

Copy link
Copy Markdown
Contributor Author

@cihangir Will you be looking to have this merged?

@dsamarin

Copy link
Copy Markdown

@ttjiaa If you were to merge this into ttjia/websocketproxy master I would happily switch over. At least for me, 3 months is a good indication that this pull request is just going to sit indefinitely. Plus it's a dead simple library that just needed a little love.

@cihangir
cihangir merged commit 944ae4a into koding:master May 18, 2018
@cihangir

Copy link
Copy Markdown
Contributor

Sorry for making this PR wait a lot. Thanks again for updating it.

@ttjiaa
ttjiaa deleted the improved-error-handling branch May 18, 2018 12:29
sudiptadeb pushed a commit to sudiptadeb/websocketproxy that referenced this pull request Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants