Repository navigation
fix: valid assault-report Nickel, no spurious manifest warning, pointer-only manifest #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7eca0cf
fix(report): emit assault-report Nickel that the Nickel parser accepts
claude 235804b
fix(cli): do not warn when no AI manifest exists
claude 66f2b59
deed: point the parent notes at where the parent is named now
claude 93469f7
deed(manifest): make 0-AI-MANIFEST.deed pointer-only (A7 Q15)
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserve warnings for manifest lookup failures.
If
0-AI-MANIFEST.deedis a self-referential symbolic link and no legacy manifest exists, this call silently uses defaults. Bothdefault_path()andload_if_exists()usePath::exists(), which converts metadata errors tofalsein Rust 1.90. The previousload_default()call attempted the read and warned. (raw.githubusercontent.com)Make the optional loader distinguish
NotFoundfrom other lookup errors. Propagate other errors to the existing warning arm, and add a regression test.Based on learnings, persisted-input I/O errors must not be collapsed into normal absence.
Source: Learnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. #302 merged before this landed, so the fix is in a follow-up PR from branch
fix/nickel-escape-and-manifest-lookup:default_pathandload_if_existsnow usetry_exists(), so only a definite absence gives the defaults, and any other lookup error reaches the warning.The Nickel
%{…}interpolation finding outside the diff is real as well. It's fixed in the same follow-up, together with JSON's\b,\fand\u001fescapes, which Nickel rejects.Generated by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis chain
Script executed:
Length of output: 5673
Script executed:
Length of output: 4830
@hyperpolymathThanks. I checked the manifest lookup changes in#303. The new symlink test callsload_if_existsdirectly, so it does not coverdefault_pathor the startup warning.Please add a CLI regression for a symlink loop with no legacy manifest, and check legacy fallback when the deed is absent. I did not run the tests. I’m not marking the finding as addressed while
#303is unmerged and that coverage is missing.If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
You are interacting with an AI system.