Skip to content

fix(ci): boj-build passes context through env and posts only over https - #299

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/boj-build-workflow
Nov 14, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/boj-build-workflow

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

This is one of the departure fixes the owner approved on 2026-11-14, and the same fix as hyperpolymath/chora-registry#116 (merged). boj-build.yml had two problems:

  • It wrote ${{ github.repository }} and ${{ github.ref_name }} directly into run:, which allows shell injection.
  • It POSTed in clear text to http://boj-server.local:7700. A GitHub-hosted runner can't resolve that mDNS name, so under continue-on-error the step always failed silently.

Changes

  • The GitHub context goes through env:. The body is built with jq -cn --arg.
  • The URL comes from the BOJ_SERVER_URL secret or variable. With no URL set, the job does nothing.
  • curl runs with --proto '=https', and an http URL skips with a warning (HTTPS-only rule).
  • Adds a concurrency group, persist-credentials: false, and a warning in place of continue-on-error. The duplicated actions-lock header lines are removed.
  • The uses: line is unchanged, so actions.lock needs no refresh.

Verification

  • shellcheck passes on the extracted run script.
  • The script was run with the URL unset, with an http URL, and with an unreachable https URL. It exits 0 each time and logs why.

Generated by Claude Code

boj-build.yml wrote ${{ github.repository }} and ${{ github.ref_name }}
straight into run:, which allows shell injection, and POSTed in clear
text to http://boj-server.local:7700. A GitHub-hosted runner can never
resolve that mDNS name, so the step always failed silently under
continue-on-error.

This is the fix already merged in chora-registry#116, and the form
standards' own boj-build.yml uses:
- context goes through env:, the body is built with jq --arg;
- the URL comes from the BOJ_SERVER_URL secret or variable, the job
  does nothing without one, and curl runs with --proto '=https'
  (an http URL skips with a warning);
- concurrency group, persist-credentials: false, and a warning in place
  of continue-on-error; the duplicated actions-lock header lines go.

The uses: line is unchanged, so actions.lock needs no refresh.

Verification: shellcheck passes on the run script. It exits 0, with
the reason logged, for an unset URL, an http URL and an unreachable
https URL.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d520b14a-3ade-4214-b653-45ff9cff8c3c
Commits

Reviewing files that changed from the base of the PR and between 6262892 and fb511c7.

Files selected for processing: 2

  • .github/workflows/boj-build.yml
  • panic-attack_chora.deed
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

- name: Trigger BoJ Server (Casket/ssg-mcp)
# GitHub context goes through env, never into the script text.
env:
BOJ_URL: ${{ secrets.BOJ_SERVER_URL || vars.BOJ_SERVER_URL }}
Hypatia RE001 on #299: the reworked trigger-boj job now reads
secrets.BOJ_SERVER_URL, and it neither installs harden-runner nor appears
in an egress declaration. The repo deed now carries one top-level
(egress …) clause for it:
- :secrets ("BOJ_SERVER_URL"), the only secret the job references;
- :endpoints, the URL held in that secret or in the variable of the same
  name;
- :enforcement none, which is the true answer: nothing holds the job to
  that host at run time; the workflow refuses any URL that is not https.

A declaration, not a new `uses:`, so actions.lock is unchanged.

Verification: deed_lint passes on panic-attack_chora.deed, and so does
deed_lint --egress (1 egress job).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC
@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 14, 2026 20:53
@hyperpolymath
hyperpolymath merged commit 656b248 into main Nov 14, 2026
60 of 61 checks passed
@hyperpolymath
hyperpolymath deleted the fix/boj-build-workflow branch November 14, 2026 20:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T20:56:05.131994Z fb511c7 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-14T20:57:10.227073Z fb511c7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants