Repository navigation
fix(ci): boj-build passes context through env and posts only over https - #299
Conversation
boj-build.yml wrote ${{ github.repository }} and ${{ github.ref_name }}
straight into run:, which allows shell injection, and POSTed in clear
text to http://boj-server.local:7700. A GitHub-hosted runner can never
resolve that mDNS name, so the step always failed silently under
continue-on-error.
This is the fix already merged in chora-registry#116, and the form
standards' own boj-build.yml uses:
- context goes through env:, the body is built with jq --arg;
- the URL comes from the BOJ_SERVER_URL secret or variable, the job
does nothing without one, and curl runs with --proto '=https'
(an http URL skips with a warning);
- concurrency group, persist-credentials: false, and a warning in place
of continue-on-error; the duplicated actions-lock header lines go.
The uses: line is unchanged, so actions.lock needs no refresh.
Verification: shellcheck passes on the run script. It exits 0, with
the reason logged, for an unset URL, an http URL and an unreachable
https URL.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
| - name: Trigger BoJ Server (Casket/ssg-mcp) | ||
| # GitHub context goes through env, never into the script text. | ||
| env: | ||
| BOJ_URL: ${{ secrets.BOJ_SERVER_URL || vars.BOJ_SERVER_URL }} |
Hypatia RE001 on #299: the reworked trigger-boj job now reads secrets.BOJ_SERVER_URL, and it neither installs harden-runner nor appears in an egress declaration. The repo deed now carries one top-level (egress …) clause for it: - :secrets ("BOJ_SERVER_URL"), the only secret the job references; - :endpoints, the URL held in that secret or in the variable of the same name; - :enforcement none, which is the true answer: nothing holds the job to that host at run time; the workflow refuses any URL that is not https. A declaration, not a new `uses:`, so actions.lock is unchanged. Verification: deed_lint passes on panic-attack_chora.deed, and so does deed_lint --egress (1 egress job). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |



Summary
This is one of the departure fixes the owner approved on 2026-11-14, and the same fix as hyperpolymath/chora-registry#116 (merged).
boj-build.ymlhad two problems:${{ github.repository }}and${{ github.ref_name }}directly intorun:, which allows shell injection.http://boj-server.local:7700. A GitHub-hosted runner can't resolve that mDNS name, so undercontinue-on-errorthe step always failed silently.Changes
env:. The body is built withjq -cn --arg.BOJ_SERVER_URLsecret or variable. With no URL set, the job does nothing.--proto '=https', and an http URL skips with a warning (HTTPS-only rule).persist-credentials: false, and a warning in place ofcontinue-on-error. The duplicated actions-lock header lines are removed.uses:line is unchanged, soactions.lockneeds no refresh.Verification
Generated by Claude Code