Repository navigation
feat(assail): route languages through a tested table; retire the vacuous PA1 #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8427d2b
187907f
5592b25
39db4e3
671c3a9
e12b823
d4a68ed
36f1055
b332b5f
9986ca4
7070cb8
680af33
c7b1c44
4f51cca
55ffcc9
71111f9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,24 @@ | |
|
|
||
| === [Unreleased] | ||
|
|
||
| ==== Fixed — the Idris2 ABI proofs are type-checked, and the stripping proof is re-proved | ||
|
|
||
| * No CI job had ever type-checked `+src/abi/+`, and as committed none of its | ||
| five modules checked. A new `+idris-abi+` job (`+proven-tests.yml+`, using | ||
| `+scripts/ci/check-idris-abi.sh+`) now checks all five on every PR with Idris2 | ||
|
Comment on lines
+7
to
+9
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct the module count in the changelog. The entry says none of the "five modules" checked, and that Replace "five" with "four", or say that the job checks all modules in
|
||
| 0.7.0. It fails on a type error, on a missing `+%default total+`, or on | ||
| `+believe_me+`, `+assert_total+`, `+assert_smaller+`, `+postulate+` or | ||
| `+idris_crash+`. | ||
| * `+Stripping.idr+`: the 2026-06-02 proof of `+stripLineCommentsIdempotent+` | ||
| never type-checked, so it is re-proved through two facts: stripping is the | ||
| identity on text with no `+//+`, and the strippers' output has no `+//+`. The | ||
| strippers are restated with explicit `+Bool+` tests. An exhaustive run over | ||
| 29,524 inputs shows they behave exactly as before. | ||
| * `+Types.idr+`: adds the missing `+Eq Severity+` that `+Ord+` needs, and fixes | ||
| the `+LangId+` declaration syntax. | ||
| * `+PROOF-NEEDS.adoc+` and `+EXPLAINME.adoc+` now say that the earlier claims had | ||
| no receipt. | ||
|
|
||
| ==== Added — `+assail --output-format kyaml+` writes a KYAML copy | ||
|
|
||
| * With `+--output-format kyaml+` and `+--output report.json+`, `+assail+` writes | ||
|
|
@@ -12,6 +30,10 @@ may be the same file: a symbolic link at any of their paths, or two existing | |
| paths that are hard links to one file, is refused before anything is written. | ||
| So is a path that exists but is not a regular file (a directory, say) or that | ||
| cannot be looked up, such as a derived name over the filesystem's length limit. | ||
| Each output is also opened for writing before anything is written (an absent | ||
| one is created and removed again), so a read-only copy or sidecar, or a | ||
| directory the caller cannot create files in, is refused too, instead of | ||
| failing after the report has been replaced. | ||
| These checks run before the writes, so a link swapped in between a check and | ||
| its write is not caught, and a crash can leave a partial file: the planned | ||
| generation-directory publish is meant to close both. | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the module list in the job comment.
The comment lists PA1 among the modules this job checks. This PR retires
PatternCompleteness.idr(PA1). The comment is stale after that removal. The job now checks four modules:AttestationUnforgeability,ClassificationSoundness,StrippingandTypes. Update the list.