Repository navigation
Conversation
Handle template start tags with the in-head rules and a simplified in-template phase so <template> before <body> lands in <head>, matching WHATWG insertion-mode requirements. Contents remain ordinary children. Fixes html5lib#595
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before this change, a leading
<template>was treated as an ordinary body element: InHead closed the head and reprocessed the token, so the element landed under<body>.WHATWG says a
templatestart tag in the "in body" insertion mode must use the "in head" rules, which place the element in<head>. This PR:templatein InHead (and the AfterHead / InBody "process in head" lists)Fixes #595
Test plan
pytest html5lib/tests/test_parser2.py(12 passed)<template></template>and<template>hi</template>puttemplateunderhead