Skip to content

Renamed BusState members and added SocketcanBus.state override - #847

Closed
bggardner wants to merge 1 commit into
hardbyte:developfrom
bggardner:develop
Closed

bggardner wants to merge 1 commit into
hardbyte:developfrom
bggardner:develop

Conversation

@bggardner

Copy link
Copy Markdown

RE: #736

@zariiii9003

Copy link
Copy Markdown
Collaborator

I agree that this should be fixed as the naming is very confusing.
But i think you did not consider that BusState.Active and BusState.Passive was used to distinguish active and silent mode on some (or all?) interfaces.

It might be better to create a new Enum ErrorState and rename BusState to BusMode or something like that.

@mergify
mergify Bot requested a review from hardbyte November 16, 2020 00:19
@felixdivo

Copy link
Copy Markdown
Collaborator

#736 should first reach a consensus. Afterward, this PR might be reopened again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants