Repository navigation
Conversation
On Windows, reopening a `gs_usb` CAN adapter for a subsequent operation can fail with: `usb.core.USBError: [Errno 13] Access denied (insufficient permissions)`
zariiii9003
reviewed
Nov 11, 2026
| pass | ||
| finally: | ||
| usb.util.dispose_resources(gs_usb.gs_usb) | ||
| usb.util.dispose_resources(self.gs_usb.gs_usb) |
Collaborator
There was a problem hiding this comment.
instead of this repetition, i'd prefer a try-finally around the whole function body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, reopening a gs_usb CAN adapter for a subsequent operation can fail with:
usb.core.USBError: [Errno 13] Access denied (insufficient permissions)
In my application, the first CAN operation completed successfully, but opening the adapter for the second operation failed. The device remained discoverable.
Fix
Explicitly dispose of the underlying PyUSB device resources during GsUsbBus.shutdown().
Testing
Tested on Windows 10 with Python 3.11, python-can 4.6.1, gs_usb 0.3.1, and a CANBUS adapter using WinUSB.
After adding usb.util.dispose_resources(self.gs_usb.gs_usb) to the shutdown method, I was able to complete a second operation successfully.
Further testing of repeated open/close cycles has been completed locally.
Type of Change