Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling an asynchronous input read can leave a readiness callback that later reads the next event and tries to complete an already cancelled Future. This reports
InvalidStateError; forasync_read_one()andasync_read_loop()it also consumes an event that a later read should receive.Check that the destination Future is still pending before reading or advancing a batch. Retrieve batch exceptions even after cancellation, while preserving the original exception for active readers.
Fixes #123.
Validation: 12 native pipe/selector tests pass, covering all three async read APIs, cancellation followed by another read, successful reads and injected read errors. Six cancellation cases fail on main. The full suite has 23 passes and six failures requiring
/dev/uinput; the same six hardware failures occur on clean main. Package build, wheel build and the CI Pylint error check pass on Python 3.14. No input hardware was exercised.