Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Add a py.typed file for submodule #625

Closed

Description

@crwilcox

To be in accordance with PEP 561 we should add a py.typed file to google/cloud/datastore/py.typed

The file can be empty but does need to be present for some type checkers.

Also, for this to work, google/cloud/spanner.py needs to be restructured to google/cloud/spanner/init.py

See googleapis/python-firestore#447 for additional context

Activity

  1. crwilcox commented on Oct 13, 2021

    @crwilcox
    ContributorAuthor

    Do note, you may need to run mypy, pyright, pytype against our samples before merging. It will ensure that we aren't exposing users to failing type checks.

    Ideally we would add this to CI as well, to avoid future breakage.

  2. added
    type: processA process-related concern. May include testing, release, or the like.
    and removed
    🚨This issue needs some love.
    triage meI really want to be triaged.
    on Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: spannerIssues related to the googleapis/python-spanner API.type: processA process-related concern. May include testing, release, or the like.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions