Skip to content

Evaluate using runtime.CallersFrames internally. #10

Closed

Description

@ChrisHines

runtime.CallersFrames was added in Go 1.7. Using it could clean up some of the internals of this package and eliminate the need for the findSigpanic function.

Activity

  1. dkushner commented on Jun 12, 2017

    @dkushner

    So, having submitted a PR for this, I can say it definitely does clean up a lot of the internal stack navigation logic but it seems to come with a decently heavy performance hit. Granted, stack generation is not really a thing that most applications are going to be doing at a high frequency but for things like logging frameworks, that may be a bit of a big deal.

    There could also simply be inefficiencies in my code, so if anyone can give it a look over, perhaps that will shave off some time. The fact that this method performs far more allocations than the previous method is unavoidable, however.

  2. ChrisHines commented on Jun 12, 2017

    @ChrisHines
    MemberAuthor

    Thanks for giving this a shot. I'll review your PR soon.

  3. ChrisHines commented on Nov 12, 2017

    @ChrisHines
    MemberAuthor

    Closed by #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions