Repository navigation
Fix collection API check skip flag - #5450
Closed
6ys72kyh5v-ship-it wants to merge 1 commit into
Closed
6ys72kyh5v-ship-it wants to merge 1 commit into
6ys72kyh5v-ship-it wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change requiring SKIP_COLLECTION_API_CHECKS to equal "1" before skipping collection API checks.
No open issues 🎉
What changed in this PR
This PR corrects the skip flag for collection API validation tests so checks are disabled only when explicitly requested.
Changes:
- Require
SKIP_COLLECTION_API_CHECKSto equal"1"to skip checks, rather than skipping whenever the variable is set.
| File | Description |
|---|---|
test/collections_test.rb |
Uses an explicit "1" comparison for the collection API check skip flag. |
Review effort: Balanced (auto)
6ys72kyh5v-ship-it
marked this pull request as draft
November 10, 2026 09:33
6ys72kyh5v-ship-it
marked this pull request as ready for review
November 10, 2026 09:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png, square, dimensions 288x288, size <= 75 kB)index.md)Curating a new topic or collection
https://github.com/topics/[NAME]orhttps://github.com/collections/[NAME])*.pngimage (if applicable) andindex.mdindex.mdconform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docsSomething that does not neatly fit into the binary options above
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.