Skip to content

Fix collection API check skip flag - #5450

Closed
6ys72kyh5v-ship-it wants to merge 1 commit into
github:mainfrom
6ys72kyh5v-ship-it:main
Closed

6ys72kyh5v-ship-it wants to merge 1 commit into
github:mainfrom
6ys72kyh5v-ship-it:main

Conversation

@6ys72kyh5v-ship-it

@6ys72kyh5v-ship-it 6ys72kyh5v-ship-it commented Nov 10, 2026 •

Copy link
Copy Markdown

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@6ys72kyh5v-ship-it
6ys72kyh5v-ship-it requested a review from a team as a code owner November 10, 2026 09:31
Copilot AI auto review requested due to automatic review settings November 10, 2026 09:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change requiring SKIP_COLLECTION_API_CHECKS to equal "1" before skipping collection API checks.

No open issues 🎉

What changed in this PR

This PR corrects the skip flag for collection API validation tests so checks are disabled only when explicitly requested.

Changes:

  • Require SKIP_COLLECTION_API_CHECKS to equal "1" to skip checks, rather than skipping whenever the variable is set.
File Description
test/​collections_test.rb Uses an explicit "1" comparison for the collection API check skip flag.

Review effort: Balanced (auto)

@6ys72kyh5v-ship-it
6ys72kyh5v-ship-it marked this pull request as draft November 10, 2026 09:33
@6ys72kyh5v-ship-it
6ys72kyh5v-ship-it marked this pull request as ready for review November 10, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants