Skip to content

Short screens: keep controls reachable and focus visible below dialog titles - #80

Merged
fenerax merged 5 commits into
mainfrom
fix/w12-short-height-layout
Nov 1, 2026
Merged

fenerax merged 5 commits into
mainfrom
fix/w12-short-height-layout

Conversation

@fenerax

@fenerax fenerax commented Nov 1, 2026

Copy link
Copy Markdown
Owner

What changes for players

Players can reach controls on very short screens and keep keyboard focus visible below dialog titles.

Checks

  • Codex Cloud: Final tests: targeted 408 passed, 0 failed, 1 skipped; quick 3,012 passed, 0 failed, 68 skipped. Chromium covered all 12 height/font/notice combinations. Comparisons passed all 776 candidate checks; START recorded 188 failures.
  • Local: short-height-browser 1/0 (172 s, real Chrome), accessibility-focus 14/0, cache-comparison 4/0. The harness now falls back to findChrome() instead of a hard-coded /usr/bin/chromium.

Written by Codex (Cloud job p-w12-high-zoom-reflow, START a781c22). Claude reviewed it, ran the focused tests locally and wrote the notes above.

🤖 Generated with Claude Code

… titles

Players can reach controls on very short screens and keep keyboard focus visible below dialog titles.

Written by Codex.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-01T09:06:41.988850Z
We couldn’t complete this review. Comment @codex review to try again.
7c58b44 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Replace the external Playwright dependency with the existing Chrome DevTools helpers while preserving native keyboard traversal, clipping, hit ownership and all viewport/font/notice cases. Skip only when Chrome is unavailable and report completed checks in TAP diagnostics.

Written by Codex.
@fenerax

fenerax commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

737ea42 ports the short-height browser test from Playwright to the repo's own CDP helper, so it now runs in CI. It skips only when Chrome is missing. All checks are kept. Results: locally 1 passed (12 cases, 666 checks). With the close-button layout deliberately broken it fails with 21 geometry failures. The standalone baseline mode passes 224 checks.

🤖 Generated with Claude Code

@fenerax
fenerax merged commit da16354 into main Nov 1, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant