[tyrelsouza]

References #368

I models how I did the __getitem__ and __setitem__ after the Headers one, so I chose to normalize the keys to lower.

First time doing Python in a while so figured I'd try to contribute.

[sethmlarson]

Hey Tyrel, thanks for opening this! 👋 I didn't know you were allowed to write Python anymore 😉

[tyrelsouza]

Looking at this comment from @florimondmanca, my __setitem__ doesn't contribute any fixes towards multi-valued queries, wonder if that should be addressed first, or if there's a deeper issue if I keep this __setitem__.

Wonder if the solution is to instead of replace, if a value is there, turn the value into the first item in a list, and then append. (or defaultdict(list) and any rendering always expands upon that?) (thinking aloud I guess..)

[florimondmanca]

@tyrelsouza I think #366 will require us to switch the query Paramus data structure to a multidict of some sort. IMO this can (should?) be addressed later — when we make the switch, we’ll come back here and merge multidicts instead of regular dictionaries.

[florimondmanca]

Forget about what I said earlier about multidicts — that's obviously already what we're using.

I played around with the bug from #366 and it turns out it can be fixed independently from this. I'll file a fix in a sec. :-) Edit : filed #374

[florimondmanca]

Looks great! One extra thing we can do is update the developer interface to show that Client now accepts and exposes params too. Would you like to take that on?

[tyrelsouza]

Sure! I can get to that in two hours. If you don't want to have to wait that long I won't be hurt if I don't do it!

[sethmlarson]

Thanks @tyrelsouza! Merging this now :)