Repository navigation
Use a certificate issued from the trustme CA in tests - #357
Merged
Merged
Conversation
JayH5
commented
Sep 18, 2019
| lifespan="off", | ||
| ssl_certfile=cert_pem_file, | ||
| ssl_keyfile=cert_private_key_file, | ||
| host="localhost", |
Contributor
Author
There was a problem hiding this comment.
This is a bit of a less-than-ideal workaround for cert validation 😕. Since the server URL that the client uses is built using this host value (maybe it shouldn't be?) it needs to match the certificate name.
JayH5
commented
Sep 18, 2019
| def cert_pem_file(example_cert): | ||
| with example_cert.cert_pem.tempfile() as tmp: | ||
| def cert_pem_file(localhost_cert): | ||
| with localhost_cert.cert_chain_pems[0].tempfile() as tmp: |
Contributor
Author
There was a problem hiding this comment.
From the trustme docs: "The zeroth entry in this list is the actual PEM-encoded certificate..."
Just including this cert and not the whole chain is fine, since there are no intermediary CA certs.
sethmlarson
self-requested a review
September 18, 2019 21:42
sethmlarson
approved these changes
Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354