Repository navigation
Conversation
The live restore section only described which containers the option applies to, which reads as if live restore and Swarm mode can be enabled together. The daemon refuses to start when both are enabled.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Removing a node from the Swarm doesn't clear the node's local Swarm state, so the daemon still fails the compatibility check when it restarts. Pointing readers at that option sent them into a loop: docker swarm leave needs a running daemon, and the daemon doesn't start while live restore is enabled. Disabling live restore is the step that unblocks the daemon. Mention leaving the Swarm only after the daemon is back.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Live restore and Swarm mode" section only described which containers the
option applies to. That reads as if live restore and Swarm mode can be enabled
together on the same daemon, with live restore handling standalone containers
and Swarm handling the services. They can't: the daemon refuses to start when
live-restoreis enabled on a node that is part of a Swarm.This adds a short paragraph to that section which:
Change is limited to
content/manuals/engine/daemon/live-restore.md. I didn'ttouch the existing wording above the new paragraph.
A follow-up commit corrects the recovery step. Removing the node from the Swarm
doesn't clear the node's local Swarm state, and the daemon reads that state
before it connects to the cluster, so the check keeps failing.
docker swarm leavealso needs a running daemon. Disabling live restore is what gets thedaemon back; leaving the Swarm comes after that.
Verification
npx --no-install rumdl fmtandrumdl check: no issues.valeon the file: the added lines report nothing. The file also reports oneexisting error and one suggestion at lines 29 and 30 (
Docker Desktopandclick); those are unchanged by this PR and were already reported onupstream/main.docker buildx bake validate|testlocally (no Docker on thismachine), so the Hugo build layers are unverified until CI runs.
Related issues or tickets
Closes #26424
Reviews
Generated by DeepSeek Harness, a coding agent. It drafted the change and this
description.