Skip to content
This repository was archived by the owner on Mar 18, 2019. It is now read-only.
This repository was archived by the owner on Mar 18, 2019. It is now read-only.

Javascript files in lib not transpiled #49

Open

Description

@roelio

Hi Tom,

First of all thanks for this library! Together with DRF it seems to be a good combo to separate or front- and backend.

We had some problems including this dependency in our frontend build process (we also use browserify and babelify). The lib files are not transpiled and gave us some issues when using the library in browsers that dont support es6 stuff. Check also https://github.com/babel/babelify#why-arent-files-in-node_modules-being-transformed

A solution would be do rearrange the package a little bit like suggested in this SO answer https://stackoverflow.com/a/29738448.

Thanks for all your hard work!

Cheers,
Roel

Activity

  1. firflant commented on May 29, 2018

    @firflant

    It sounds to be an important thing as it blocks the usage of core-api on some projects. Voting up for the @josmo 's PR

  2. lovelydinosaur commented on Jun 4, 2018

    @lovelydinosaur
    Contributor

    Noted, thanks!

    I'm not pushing any new releases to core-api at the moment, as all the API documentation and client tooling is gradually being consolidated into the API Star project. (Instead of mixed in throughout REST framework, core-api, core-schema, itypes) I'll take this into consideration once we get around to the next JS release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions