This repository was archived by the owner on Oct 24, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 24, 2022. It is now read-only.
Don't use SSLv3 #39
Description
We have recently disabled support for SSLv3 at GitHub, as it is a very old version of the SSL protocol that is now also known to be vulnerable:
http://googleonlinesecurity.blogspot.com/2014/10/this-poodle-bites-exploiting-ssl-30.html
https://www.imperialviolet.org/2014/10/14/poodle.html
We have had several reports from GitHub users using the Pygithub3 library, complaining of failing requests due to the use of SSLv3 in the library. Here's an example traceback that has been reported:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/pygithub3/services/users/__init__.py", line 36, in get
return self._get(request)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/pygithub3/services/base.py", line 142, in _get
response = self._client.get(request, **kwargs)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/pygithub3/core/client.py", line 83, in get
response = self.request('get', request, **kwargs)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/pygithub3/core/client.py", line 70, in wrapper
return func(self, verb, request, **kwargs)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/pygithub3/core/client.py", line 76, in request
response = self.requester.request(verb, request, **kwargs)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/requests/sessions.py", line 252, in request
r.send(prefetch=prefetch)
File "/Users/ray/virtualenv/pygh3/lib/python2.7/site-packages/requests/models.py", line 632, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 8] _ssl.c:504: EOF occurred in violation of protocol
/cc @copitux
Activity
grapefrukt commentedon Oct 21, 2014
As far as I can tell this is fixed by upgrading to a newer version of requests, this requires a minor change to the Client class, but it's no biggie. @ray-dino has a fork with the changes here:
ray-dino/python-github3@copitux:master...master
ray-dino commentedon Oct 22, 2014
There's also a pull request for the fix by @conorbranagan here: #35
copitux commentedon Oct 23, 2014
Merged
codingisacopingstrategy commentedon Nov 23, 2014
Hello, I installed through
pip install pygithub3and I’m still getting this error. Is it possible that you didn’t push an upgrade to pypi?Cheers,
copitux commentedon Nov 28, 2014
Updated @codingisacopingstrategy
codingisacopingstrategy commentedon Nov 28, 2014
Thanks!