Repository navigation
ci: wait for the init server to finish before the security checks #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 bug · medium
Bound the container init-wait loops
The new wait loops at
.github/workflows/docker.yml:93and.github/workflows/docker.yml:121are unboundeduntil ...; do sleep 1; donewith no iteration cap, and the adjacentpg_isreadyloops at lines 94 and 122 are likewise unbounded. If the container fails to initialize (e.g. initdb error, badPOSTGRES_PASSWORD, OOM), the log never containsPostgreSQL init process complete, and since anuntilcondition is exempt fromset -e/pipefail, the step spins until the GitHub Actions job timeout (default 6 hours). This burns runner minutes and masks the real failure; on the push job it also delays manifest tagging oflatest/18.📋 Prompt for AI Agents
In .github/workflows/docker.yml at lines 93-94 and the duplicate at lines 121-122, replace the unbounded
until ...; do sleep 1; doneloops (both thedocker logs | greploop and thepg_isreadyloop) with bounded loops: keep an attempts counter incremented each sleep, and after ~120 attempts (2 minutes)exit 1while printingdocker logs postgis-verifyso a failed container init fails the step instead of hanging until the 6-hour job timeout.