Repository navigation
ci: wait for the real server, not the init-time one, before the security gates - #20
Open
pyramation wants to merge 1 commit into
Open
pyramation wants to merge 1 commit into
pyramation wants to merge 1 commit into
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No blocking issues — approved ✅; 1 nitpick below. 🧹 Nitpicks (1) — 🟢 1 low
The change updates
One low-severity note: the Reviewed commit: 32fd3e7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
mainrun for #19 failed its amd64 "Verify PostGIS security (pushed digest)" step withpsql: error: connection to server on socket … failed: No such file or directory, so the manifest job was skipped and:18was not moved to the pgvector 0.8.7 build.Cause: the step waits with
pg_isready -U postgresover the unix socket. The image entrypoint first starts a temporary server forinitdbscripts that listens on the socket only, then stops it and starts the real one. The wait can succeed against the temporary server and the first gate script then connects while nothing is running. This race predates #19 (same wait line; it passed on the PR run and lost on themainrun).Fix: wait with
pg_isready -h 127.0.0.1, which only the real server answers. Observed locally onpostgres-plus:18while starting a container: socket check ready while TCP check still not ready, then both ready.Applied to both the PR and pushed-digest verify steps.
Link to Devin session: https://app.devin.ai/sessions/526ad15103ba4700897c0cf7aa8bbdfc
Open in Devin Desktop: https://app.devin.ai/desktop/session/526ad15103ba4700897c0cf7aa8bbdfc?variant=devin
Requested by: @pyramation
🟢 Devin Review found nothing to fix · View findings