Repository navigation
Conversation
|
Review complete. 🟡 1 medium 💬 Inline comments (1)
This PR aligns the plugin's two public-URL surfaces on a single bucket-qualified layout and documents the CDN contract it implies. New projections and the public
Reviewed commit: 00cd02a |
There was a problem hiding this comment.
Unifies the public file-URL layout to <prefix>/<physical bucket>/<key> via a new buildPublicFileUrl helper used by both the upload projection and the computed downloadUrl.
Key findings
- 🟡 Backfill persisted projection
urlto bucket-qualified layout — file-projection.ts:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the deprecated
urlfield fromFileProjection. Fresh and deduplicated uploads return the file ID, object key, bucket ID, MIME type, size, and optional filename. Callers can use the ID to query the file row’sdownloadUrlonce the upload is confirmed.Update the GraphQL field description, storage schema snapshot, SDK descriptions, and plugin README to document this contract. Drop the pre-launch upgrade guidance.
All 101 plugin tests passed locally, including RustFS integration tests and regression coverage for public uploads with a configured public URL prefix. The package built for CommonJS and ESM, and ESLint passed on the changed plugin TypeScript files.