Repository navigation
Add a few overloaded methods for eval & trace - #501
Closed
copybara-service[bot] wants to merge 0 commit into
Closed
copybara-service[bot] wants to merge 0 commit into
copybara-service[bot] wants to merge 0 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_699122409
branch
2 times, most recently
from
November 25, 2024 07:36
39ab5b6 to
1f65d7e
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_699122409
branch
7 times, most recently
from
November 26, 2024 11:56
16eed04 to
96163dd
Compare
copybara-service
Bot
force-pushed
the
test_699122409
branch
from
November 26, 2024 12:05
96163dd to
3504e44
Compare
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 30, 2026
CEL specification PR #501 widens valid CEL durations from roughly ±290 years (64-bit signed nanoseconds) to the full `google.protobuf.Duration` range (±10,000 years, -315,576,000,000.999999999s to +315,576,000,000.999999999s) so every valid `Timestamp` difference is representable as a CEL duration, and rejects out-of-range `google.protobuf.Duration` and `google.protobuf.Timestamp` message literals at construction. Update duration validation, timestamp and duration arithmetic, `timestamp(int)` epoch-second bounds, protobuf message literal construction, and Z3 verifier bounds and witness formatting to enforce full protobuf duration and RFC 3339 timestamp bounds while preserving unvalidated field selection on existing protobuf messages. Replace `threeten-extra` duration string parsing with a zero-allocation Go `time.ParseDuration`-compatible parser supporting the ±10,000-year range (removing the `org.threeten:threeten-extra` dependency), deprecate `CelOptions.Builder.enableTimestampOverflowCheck` as a no-op, and re-enable the skipped duration and timestamp spec conformance suites. PiperOrigin-RevId: 1010820757
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 31, 2026
CEL specification PR #501 widens valid CEL durations from roughly ±290 years (64-bit signed nanoseconds) to the full `google.protobuf.Duration` range (±10,000 years, -315,576,000,000.999999999s to +315,576,000,000.999999999s) so every valid `Timestamp` difference is representable as a CEL duration, and rejects out-of-range `google.protobuf.Duration` and `google.protobuf.Timestamp` message literals at construction. Update duration validation, timestamp and duration arithmetic, `timestamp(int)` epoch-second bounds, protobuf message literal construction, and Z3 verifier bounds and witness formatting to enforce full protobuf duration and RFC 3339 timestamp bounds while preserving unvalidated field selection on existing protobuf messages. Replace `threeten-extra` duration string parsing with a zero-allocation Go `time.ParseDuration`-compatible parser supporting the ±10,000-year range (removing the `org.threeten:threeten-extra` dependency), deprecate `CelOptions.Builder.enableTimestampOverflowCheck` as a no-op, and re-enable the skipped duration and timestamp spec conformance suites. PiperOrigin-RevId: 1010820757
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 31, 2026
CEL specification PR #501 widens valid CEL durations from roughly ±290 years (64-bit signed nanoseconds) to the full `google.protobuf.Duration` range (±10,000 years, -315,576,000,000.999999999s to +315,576,000,000.999999999s) so every difference between valid `Timestamp` values is representable as a CEL duration. Update duration bounds checking, timestamp and duration arithmetic, and `timestamp(int)` epoch-second validation across both native `java.time` and protobuf runtime representations. Replace `threeten-extra` duration parsing with a zero-allocation Go `time.ParseDuration`-compatible parser supporting the ±10,000-year range (removing the `org.threeten:threeten-extra` dependency), deprecate `CelOptions.Builder.enableTimestampOverflowCheck` as a no-op, and enable the widened duration conformance tests. PiperOrigin-RevId: 1010820757
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a few overloaded methods for eval & trace