Repository navigation
APS-22957: recommend Node 24.22.1 for the sample (engines >=22.23.4, .nvmrc) - #79
Draft
karanshah-browserstack wants to merge 1 commit into
Draft
karanshah-browserstack wants to merge 1 commit into
karanshah-browserstack wants to merge 1 commit into
Conversation
….nvmrc) The engines floor (>=12.7.0) is stale: Playwright 1.57 itself needs a much newer Node. Point users of this sample at a supported, patched Node. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
Archish27
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APS-22957 row 5. This public sample says
engines.node >=12.7.0. Customers copy samples as a starting point, so that floor points them at an end-of-life Node. The floor is also stale, because the pinnedplaywright ~1.57.0needs a much newer Node anyway.package.json/package-lock.json(root entry only):engines.node>=12.7.0->>=22.23.4.nvmrc:v24.22.1(recommended)Only metadata changes. The sample is not published to npm, and
enginesonly produces a warning (EBADENGINE) on older Node.Testing
npm ci(browser download skipped)EBADENGINEwarningnode --checkon all root sample scriptsrequire('playwright')(1.57.0)I didn't run the samples against BrowserStack, because no credentials were available in this environment.
🤖 Generated with Claude Code