Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After
beeper setup --remote <url>, every command started a new OAuth login, and each one registered another "Beeper CLI" client in Desktop. I ended up with 8 of them before I noticed.Two things caused it:
setupRemotewrote the target again aftersetupOAuthTarget(or email setup) had saved it with its token, so the saved token was dropped.createClientandrequireTokenfell back to a fresh login and saved it toconfig.json. Onlydesktoptargets read auth from there, so remote and Server targets never saw it.Change
writeTargetinsetupRemote. Both setup paths already save the target with its auth.ensureDesktopToken. For a remote or Server target, the fallback login is saved on that target withsaveTargetAuth, but only when the login ran against the target's own URL. Desktop targets keep saving toconfig.jsonas before.Validation
test/remote-auth.test.ts. It runs the CLI against a local mock OAuth server with a stub browser opener. It covers setup, thecreateClientandrequireTokenfallbacks on remote and Server targets across two processes, and controls for built-in and managed Desktop.bun run checkpasses.