Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
setup --desktopnow says what it does: it creates a separate CLI-managed Beeper Desktop profile on its own port. The help text and docs point people with Desktop already running tosetup --local. If starting that profile throws, setup prints the error as a warning instead of dropping it, then still checks readiness. Server launch failures stay fatal.Why
I ran
beeper setup --desktopwith Desktop already running and expected it to use that Desktop. It created a second profile on 127.0.0.1:23374 and only reported "target unreachable". The old help text ("Set up a local Beeper Desktop target") reads like the--localbehavior, and any launch error was swallowed by the catch insetupManaged.One limit: on macOS the launch goes through a detached
open, and its exit status isn't checked, so anopenfailure there still won't show up. Catching that would mean changinglaunchDesktopApp, and I kept it out of this PR.Verification
test/setup-managed.test.tsruns the builtsetupcommand withstartProfilemocked to throw, against a local server that returns 503. It covers human and--jsonoutput, plus the Server-still-fails case. A fakeopenon PATH keeps it from launching anything.bun run lintandbun run checkpass on Bun 1.3.10 (48 pass, 3 Linux-only skips).