Skip to content

fix(cli): clarify setup --desktop and stop hiding its launch errors - #53

Open
postoso wants to merge 1 commit into
beeper:mainfrom
postoso:fix/setup-desktop-clarity
Open

postoso wants to merge 1 commit into
beeper:mainfrom
postoso:fix/setup-desktop-clarity

Conversation

@postoso

@postoso postoso commented Oct 26, 2026

Copy link
Copy Markdown

What changed

setup --desktop now says what it does: it creates a separate CLI-managed Beeper Desktop profile on its own port. The help text and docs point people with Desktop already running to setup --local. If starting that profile throws, setup prints the error as a warning instead of dropping it, then still checks readiness. Server launch failures stay fatal.

Why

I ran beeper setup --desktop with Desktop already running and expected it to use that Desktop. It created a second profile on 127.0.0.1:23374 and only reported "target unreachable". The old help text ("Set up a local Beeper Desktop target") reads like the --local behavior, and any launch error was swallowed by the catch in setupManaged.

One limit: on macOS the launch goes through a detached open, and its exit status isn't checked, so an open failure there still won't show up. Catching that would mean changing launchDesktopApp, and I kept it out of this PR.

Verification

  • New test/setup-managed.test.ts runs the built setup command with startProfile mocked to throw, against a local server that returns 503. It covers human and --json output, plus the Server-still-fails case. A fake open on PATH keeps it from launching anything.
  • Without the change, both Desktop cases fail on the missing warning.
  • bun run lint and bun run check pass on Bun 1.3.10 (48 pass, 3 Linux-only skips).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant