Repository navigation
Support nested Zarr datasets - #114
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 1467 1559 +92
=========================================
+ Hits 1467 1559 +92 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
konstntokas
force-pushed
the
konstntokas/support_nested_zarr
branch
from
November 3, 2026 09:43
67b18a6 to
52e8d3e
Compare
backup backup ready for review add issue number ruff
konstntokas
force-pushed
the
konstntokas/support_nested_zarr
branch
from
November 3, 2026 13:09
13e93fc to
700b83a
Compare
konstntokas
marked this pull request as ready for review
November 3, 2026 13:45
forman
reviewed
Nov 4, 2026
forman
left a comment
forman
left a comment
Member
There was a problem hiding this comment.
Nice. I only have minor suggestions.
|
|
||
| Type _string_. | ||
| The fully qualified name of a class or function that receives a slice item as argument(s) and provides the slice dataset. If a class is given, it must be derived from `zappend.api.SliceSource`. If the function is a context manager, it must yield an `xarray.Dataset`. If a plain function is given, it must return any valid slice item type. Refer to the user guide for more information. | ||
| The fully qualified name of a class or function that receives a slice item as argument(s) and provides a slice object. If a class is given, it must be derived from `zappend.api.SliceSource`. If the function is a context manager, it must yield an `xarray.Dataset` or `xarray.DataTree`. If a plain function is given, it must return any valid slice item type. Refer to the user guide for more information. |
Member
There was a problem hiding this comment.
Do not exceed 80 characters in a line whenever possible.
Collaborator
Author
There was a problem hiding this comment.
This is the case in the entire config.md. I applied changes to the entire docs directory so that we do not exceed 89 characters.
| return self._config.get("variables") or {} | ||
|
|
||
| @property | ||
| def group_variables(self) -> dict[str, dict[str, Any]]: |
Member
There was a problem hiding this comment.
Avoid Any whenever possible and replace it by any type or type union that is more specific than Any and represents a variable-definition (override).
Collaborator
Author
There was a problem hiding this comment.
This come from
@property
def variables(self) -> dict[str, Any]:
I change both to Sequence | dict (see docs for variables)
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
forman
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for nested Zarr structures represented by
xarray.DataTree, including atomic rollback of complete DataTree slices and optional per-group variable encoding configuration.Closes #113
Checklist (strike out non-applicable):
CHANGES.mdCHANGES.mddocs/*