Repository navigation
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a17cbe-3194-727f-96ca-257cd19df3c7 Co-authored-by: Tanvesh sarve <sarvetanvesh01@gmail.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a17cbe-3194-727f-96ca-257cd19df3c7 Co-authored-by: Tanvesh sarve <sarvetanvesh01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recorder always passes
--restore. agent-browser rejects that flag for sessions opened with--allowed-domains, and the failed command can leave the session unable to run ordinary commands.What changes
startaccepts the session's--allowed-domainslist, or readsAGENT_BROWSER_ALLOWED_DOMAINS. It saves the list for the recording and passes it to every browser command instead of--restore.--restore. For contained recordings, the recorder rejects conflicting restore environment variables before starting agent-browser.The list must be passed to
startwhen it was specified only on the browser's initial command;session infodoes not expose it to the recorder.Checked
git diff --checkpass.Not checked
startin that case.