Repository navigation
Conversation
main has a merge queue, but selftest only triggers on push, pull_request and workflow_dispatch. A queued merge group therefore never gets selftest checks, so once those checks are required the entry waits for the queue's check timeout and is removed. Add the merge_group trigger so the queue can run them. Signed-off-by: Roman Inflianskas <Roman.Inflianskas@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainhas a merge queue, butselftestonly triggers onpush,pull_requestandworkflow_dispatch. A queued merge group never starts those workflows, so once the selftest jobs are required checks, every queue entry waits for the queue's check timeout and is then removed.What changes
selftest.ymlgains themerge_grouptrigger, so the queue's temporary merge-group branch runs the same four jobs (unused imports, unit tests, sandbox machinery, action smoke test) that a pull request does.Verification
Nothing in
selftest.ymlreadsgithub.event.pull_request.*or the PR head/base refs, so the jobs behave the same under amerge_groupevent. The trigger itself can only be exercised by a real queue entry; that is not verified here.Scope
The workflow does not decide which checks the queue requires; that is branch protection.
reusable.ymlandskill-evals.ymlareworkflow_call-only and unchanged.