Repository navigation
fix: avoid default-handle collision in native profile validation - #24
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native profile validation used
hermesas a deliberately absent profile. Newer Hermes gateways can resolve that handle to the default profile, so the credential-free probe returns 200 and valid connections are rejected.Use
_, which cannot be a native profile ID, for the negative routing probe. Keep the existing 404 requirement, selected-route health identity check, and authentication order in every request family. Update the existing fixtures, documentation, and release metadata to 1.4.2.Validation: 217 unit tests passed, including the new default-handle regression across all five client request families. Another 37 loopback HTTP checks passed using real aiohttp, the production client, and pinned released/current Hermes routing functions. The released client reproduces the alias failure against the newer routing function; the fixed client succeeds and still stops before credentials when prefixes are ignored. No full Home Assistant runtime or live installation was tested.
Fixes #23.