Skip to content

Stop describing Copilot as the generated loop's reviewer in README - #181

Merged
dmccoystephenson merged 1 commit into
mainfrom
fix/readme-no-copilot-reviewer
Nov 20, 2026
Merged

dmccoystephenson merged 1 commit into
mainfrom
fix/readme-no-copilot-reviewer

Conversation

@dmccoystephenson

Copy link
Copy Markdown
Member

Summary

No tracking issue: the gap was found during a Stage A documentation-accuracy sweep.

Issues not picked this cycle: the open template-rule issues (#122–#158, #150) all change the template body and would be held behind #109. #173's create-dev-loop.md half is already fixed on main (line 652 now says "directly below the H1 heading"), and its remaining CLAUDE.md half needs separately authorized edits, like #106. #109, #114, #141, and #143 are process or verification questions with no scoped docs change.

Research grounding

Docs-only change; it does not touch the template. No RESEARCH.md finding applies.

Doc sync check

  • README.md matches what create-dev-loop.md actually does

Test plan

  • python3 scripts/check_docs.py: "Doc consistency check passed."
  • python3 -m unittest discover -s tests: ran 42 tests, OK
  • grep -rni copilot --include=*.md: outside create-dev-loop.md (tracked in Reviewer-addition edge case still tells the loop to retry with @copilot #180), the only remaining mention is the new README sentence saying Copilot is never used.
  • Behavioral /create-dev-loop run: not applicable (no Step or template change).

This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

🤖 Generated with Claude Code

The REVIEWER row of Step 4 now forbids Copilot, but README still said
the loop falls back to @copilot.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dmccoystephenson

Copy link
Copy Markdown
Member Author

Self-review rubric (performed inline in the same session; no independent reviewer):

  • Scope: PASS. Only README.md is modified, and both hunks are the two Copilot-reviewer claims.
  • Tests-new: PASS (n/a). No code changed.
  • Tests-fix: PASS (n/a). Docs correction only; no executable behavior changed.
  • Sibling structure: PASS. No new files.
  • Sibling renames: PASS. No identifiers were renamed.
  • Docs: PASS. The new wording matches the REVIEWER row at create-dev-loop.md:644 ("Primary human reviewer from CODEOWNERS or recent PRs, or unset. Never Copilot … leave REVIEWER unset and the loop goes straight to self-review"). It also matches the {{#if REVIEWER}} guard at create-dev-loop.md:338, which drops the reviewer request when REVIEWER is unset. grep -rni copilot --include=*.md finds no other doc carrying the old claim outside the template.
  • Issue resolution: PASS (n/a). No Closes; the remaining template half is tracked in Reviewer-addition edge case still tells the loop to retry with @copilot #180.
  • CI: PASS. doc-consistency is green on the PR head.
  • Placeholder parity / README Step parity / fence escaping / phase numbering / version comments: PASS (n/a). The template and the Step list are untouched; check_docs.py passed.
  • Research grounding: PASS. The body states that no finding applies to a docs-only change.
  • No back-ported specifics / gardener interface / retrofit note: PASS (n/a). create-dev-loop.md is not touched.
  • Behavioral validation: UNVERIFIED-not-applicable. There is no Step or template change.

Out-of-diff observation: create-dev-loop.md:588 still tells a generated loop to use @copilot when Copilot fails to resolve. That contradicts the Step 4 row and is filed as #180.

Do-not-auto-merge path check: only README.md changed, with 2 lines deleted. No protected path matches.

This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

@dmccoystephenson
dmccoystephenson merged commit 7ae85c4 into main Nov 20, 2026
1 check passed
@dmccoystephenson
dmccoystephenson deleted the fix/readme-no-copilot-reviewer branch November 20, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant