Repository navigation
code editor accessibility - #925
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the editor accessibility and read-only updates.
No open issues 🎉
What changed in this PR
This PR adds accessibility configuration to the shared code editor and aligns its read-only state with CodeMirror’s editing controls.
Changes:
- Add optional accessible labels and descriptions, with support for updating them after initialization.
- Update read-only mode to configure both editor editability and state-level read-only behavior.
- Extend unit tests and mocks to cover the new configuration.
| File | Description |
|---|---|
test/unit/codeEditor.test.js |
Adds accessibility tests and updates read-only expectations and mocks. |
src/lib/code-editor/CodeEditor.ts |
Adds accessible attributes, a runtime update method, and state-level read-only configuration. |
Review effort: Balanced
SharonStrats
force-pushed
the
feat/editor-accessibility
branch
from
November 10, 2026 00:12
fc084fb to
42e310e
Compare
…istry@5.0.2-3) (latest: rdflib@2.4.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.