You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 30, 2026. It is now read-only.
Linter rules should be disabled by message name not message code #32
To help code reviewers understand why a linter rule should be disabled for a line of code, the message name (e.g. unused-import) should be disabled as opposed to the code (e.g. W0611) so that reviewers don't need to look up each rule, e.g.
import typing # pylint: disable=unused-import
For the above import a reviewer could guess that it was likely disabled because it is used in a Python2-style type annotation comment and then they can look for its inclusion in a comment, whereas the following doesn't afford a reviewer much of a clue unless they've memorized the message code format/categories/look up the message code:
Activity
erikwright commentedon Mar 13, 2017
Agreed. If we put a linter rule in place for this can we make that rule output the keyword?