Repository navigation
Conversation
Storybook add-ons declare a peer dependency on the matching `storybook` release, so they have to move together. Dependabot currently opens one PR per package, which can leave the add-ons and `storybook` on different majors (e.g. SQLMesh#6164 bumped only @storybook/addon-a11y to 10.x, which breaks `storybook dev` and `storybook build` in vscode/react). - Group storybook, @storybook/*, @chromatic-com/storybook and eslint-plugin-storybook minor/patch updates into a single PR. - Ignore major bumps for those packages. A Storybook major upgrade needs to be done by hand as one coordinated migration (for example @storybook/addon-vitest 10 requires vitest 4+). Signed-off-by: mday-io <mdaytn@gmail.com>
 |
| Layer / File(s) | Summary |
|---|---|
Storybook update policy .github/dependabot.yml |
The npm configuration groups minor and patch updates for the listed Storybook packages and ignores their semver-major updates. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related PRs
- SQLMesh/sqlmesh#6164: Updates
@storybook/addon-a11y, a package covered by the new Dependabot rules.
Suggested labels: dependencies, javascript
Merge Risk: 
3ba49
-
This PR changes how Dependabot proposes Storybook-related dependency updates, so related packages are bumped together and major upgrades are deferred. It has no effect on runtime behavior. Merge risk is minimal; the author notes Dependabot's behavior can be confirmed after the change reaches main.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly and concisely describes the main changes: grouping Storybook dependencies and deferring major updates. Description check The description includes the required Description, Test Plan, and Checklist sections. It explains the problem, the configuration change, validation steps, limitations, and checklist status. Linked Issues check No active directly linked issue remains. Issue #6164is closed and supplies historical context only. Therefore, this pull request has no linked-issue coding requirements. The change does not need to i…Out of Scope Changes check The change is limited to .github/dependabot.yml. It groups Storybook minor and patch updates and ignores Storybook major updates. These changes match the pull request's stated dependency-management …Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Full details: Linked Issues check
-
Explanation
No active directly linked issue remains. Issue
#6164is closed and supplies historical context only. Therefore, this pull request has no linked-issue coding requirements. The change does not need to implement the closed issue's dependency upgrade.
Full details: Out of Scope Changes check
-
Explanation
The change is limited to
.github/dependabot.yml. It groups Storybook minor and patch updates and ignores Storybook major updates. These changes match the pull request's stated dependency-management objective. No unrelated change is shown.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Description
Dependabot opened #6164, which bumps only
@storybook/addon-a11yfrom 9.0.18 to 10.6.3 whilestorybookand the other Storybook packages stay on 9.0.18. The add-on declaresstorybook: ^10.6.3as a peer dependency, and with that mismatch bothstorybook devandstorybook buildinvscode/reactfail withNoMatchingExportError(the add-on importsSelectandTabsViewfromstorybook/internal/components, which don't exist in 9.0.18). CI didn't catch it because no job runs Storybook.This changes
.github/dependabot.ymlso that can't happen again:storybook,@storybook/*,@chromatic-com/storybookandeslint-plugin-storybookminor/patch updates into a single PR, so the add-ons andstorybookalways move together.@storybook/addon-vitest@10requiresvitest ^4 || ^5(we're on 3.2.x), and@chromatic-com/storybook@4only supports Storybook 9.I closed #6164 with
@dependabot ignore this major version. Upgrading Storybook itself is out of scope here. Ignoring majors defers that migration, so it should be picked up deliberately later.Test Plan
.github/dependabot.ymlagainst the SchemaStoredependabot-2.0JSON schema. It passes, and a misspelled key is rejected, so the check does catch errors.pnpm run build-storybookandstorybook devfail invscode/react, andbuild-storybookpasses onmain.^9.1.21, or to^10.6.3(plus@chromatic-com/storybook@^5.6.0), installs cleanly andbuild-storybook,tscand vitest pass.vscode/reacthas no stories, so this only exercises the build.main. Config errors would show up under Insights → Dependency graph → Dependabot.Checklist
make styleand fixed any issues (N/A: YAML config only, no Python or TS changes)make fast-test) (N/A: no code changed)git commit -s) per the DCOSummary by CodeRabbit