Skip to content

Binder: cleanup "warning: manual implementation of Option::map" #243

Closed

Description

@ojeda
warning: manual implementation of `Option::map`
   --> drivers/android/process.rs:189:12
    |
189 |           Ok(match self.get_existing_node(ptr, cookie)? {
    |  ____________^
190 | |             None => None,
191 | |             Some(node) => Some(self.new_node_ref(node, strong, thread)),
192 | |         })
    | |_________^ help: try this: `self.get_existing_node(ptr, cookie)?.map(|node| self.new_node_ref(node, strong, thread))`
    |
    = note: `#[warn(clippy::manual_map)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map

Activity

  1. added 3 commits that reference this issue on May 2, 2021
    0dbc84d
    51d0d59
    a193593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomers• driversRelated to the example drivers in `drivers/`.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions