Repository navigation
Sound card: says it needs a USB device port on firmware without one - #188
Merged
Merged
Conversation
On a board whose firmware has no machine.USBDevice (the ESP32-S31 builds today), opening Sound card raised AttributeError in usb.device.audio and Home came back with a traceback on the console. It now shows the missing port the way Gamepad does. Opened on a Waveshare ESP32-S31-Touch-LCD-4.3C: the status line reads "no USB device" and the message sits mid-screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On firmware with no
machine.USBDevice, such as the ESP32-S31 builds, opening Sound card raisedAttributeError: 'module' object has no attribute 'USBDevice'insideusb/device/audio.py, and the launcher fell back to Home with a traceback. The app now checks for the device port first and says what's missing, as Gamepad and MIDI Controller already do.Checked on a Waveshare ESP32-S31-Touch-LCD-4.3C by opening the app from the launcher: the status line reads "no USB device", the message is mid-screen, and nothing is printed to the console. Not re-run on a board that has a USB device port; the path there is unchanged.