Skip to content

Keep snapshot images shallow so serializing and restoring them cannot overflow the stack #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Project516 merged 7 commits into from
Nov 6, 2026
Merged

Keep snapshot images shallow so serializing and restoring them cannot overflow the stack #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bb0aced
Save the JIT's generated code in warm snapshots and compile it on eac…
Project516 Nov 6, 2026
9ae0824
Merge branch 'master' into p516/warm-jit
Project516 Nov 6, 2026
0644b59
Bound the nesting of snapshot images so v8 serialize and deserialize …
Project516 Nov 6, 2026
c6daf07
Make the warm snapshot test wait for the save that follows a library …
Project516 Nov 6, 2026
181c32e
Merge branch 'master' into p516/warm-jit
Project516 Nov 6, 2026
901ccc9
Merge remote-tracking branch 'origin/p516/warm-jit' into p516/warm-re…
Project516 Nov 6, 2026
f3f4e64
Merge remote-tracking branch 'origin/master' into p516/warm-restore-d…
Project516 Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/jvm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { intrinsics, natives as builtinNatives } from "./natives/index.ts";
import { invokePolymorphic, linkCallSite, resolveConstant } from "./indy.ts";
import { hostNative, jniNames } from "./hostnatives.ts";
import { Library } from "./library.ts";
import { dumpVM, restoreVM, snapshotKey } from "./snapshot.ts";
import { dumpVM, restoreVM, snapshotKey, SNAPSHOT_FORMAT } from "./snapshot.ts";
import type { SnapshotImage, WarmSnapshotImage } from "./snapshot.ts";
import type { SavedJit } from "./jit.ts";
import type { LibraryRequest } from "./library.ts";
Expand Down Expand Up @@ -1262,7 +1262,7 @@ export class JVM {
const build = snaps.build;
this.warmKey = JSON.stringify([snapshotKey(this, build), this.opts.classpath ?? [], this.opts.cwd ?? "/", this.props.get("sun.java.command") ?? null]);
const useWarm = (image: WarmSnapshotImage | null) => {
if (!image) return false;
if (image?.format !== SNAPSHOT_FORMAT) return false;
let mismatch: string | null;
try {
mismatch = image.warmKey === this.warmKey && image.key === snapshotKey(this, build) ? this.fs.warmTraceMismatch(image.trace) : "key changed";
Expand Down Expand Up @@ -1305,7 +1305,7 @@ export class JVM {
const key = snapshotKey(this, snaps.build);
const done = (image: SnapshotImage | null) => {
// an async load can finish after the VM was halted
if (image?.key !== key || this.exitCode !== null) return start(false);
if (image?.format !== SNAPSHOT_FORMAT || image.key !== key || this.exitCode !== null) return start(false);
try {
restoreVM(this, image, t);
} catch (e) {
Expand Down
Loading
Loading