[Project516]

Runs 49 more OpenJDK regression tests in CI. They pass now that child processes (#45), files past 4 MiB (#47) and WatchService (#46) work.

A sweep ran the process, file, channel, zip, jar, zipfs, prefs and thread test directories that were not in passing.txt, on GitHub Actions in a temporary repository. 51 tests passed, and all 51 passed a second run. Two of them, jdk/nio/zipfs/LargeEntriesTest.java (217 s) and ZipFSOutputStreamTest.java (204 s), stay out because CI keeps each test well under a third of the 600 s timeout. The other 49 go into passing.txt, with their measured durations in times.tsv so the shards stay balanced; together they add about 22 minutes of test time spread over eight shards.

By directory: 26 jdk/nio/zipfs, 4 java/util/jar, 3 each in java/util/zip, java/util/prefs, java/nio/file, java/nio/channels, java/lang/RuntimeTests and java/io/File, and 1 in java/lang/Thread.

Noticed, not fixed (37 tests still fail or time out):

• 11 hit the memory limit, for example java/nio/channels/FileChannel/Transfer2GPlus.java.
• 3 need com.sun.management.UnixOperatingSystemMXBean, for example java/io/FileOutputStream/UnreferencedFOSClosesFd.java.
• File system behavior: requested POSIX permissions (PosixFileAttributeView/Basic.java) and atomic append (FileChannel/AtomicAppend.java).
• Timeouts: WatchService/DeleteInterference.java and the virtual thread stress test NotifiedThenTimedOutWait.java.
• Others in cleanup, virtual thread parking, stack walking, zip handling and paths; some TestNG summaries give only a failure count.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 7147c3ae-f9e0-4927-a40e-0dd76d755d99

Commits

Reviewing files that changed from the base of the PR and between a5be090 and fd04cac.

Files ignored due to path filters: 1

• test/jtreg/times.tsv is excluded by !**/*.tsv

Files selected for processing: 1

• test/jtreg/passing.txt

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

• Tests
  • Updated the set of tests recognized as passing across file handling, runtime shutdown, virtual threads, networking and I/O, archives, preferences, and filesystems. The update also removes several previously listed tests.

The jtreg passing-test list adds OpenJDK tests across several Java APIs and removes selected file I/O, NIO Files, and preferences test entries.

Changes: Passing-Test List

Layer / File(s)	Summary
File I/O and shutdown tests test/jtreg/passing.txt	Adds file I/O and runtime shutdown tests, including a virtual-thread shutdown-hook test. Removes DeleteOnExitLong.java.
NIO channels and filesystem tests test/jtreg/passing.txt	Adds channel, FileChannel, FileStore, FileSystem, and Files tests. Removes six Files test entries.
JAR, ZIP, and zipfs tests test/jtreg/passing.txt	Adds JAR and ZIP tests, plus 26 zipfs tests covering operations, validation, updates, attributes, and channels.
Preferences tests test/jtreg/passing.txt	Adds three preferences tests and removes six preferences test entries.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related issues

• Report a file system's block size and space, as statvfs gives them #42: The issue calls for wider OpenJDK verification, and this change adds OpenJDK tests to the passing-test list.

Possibly related PRs

• Project516/java-web#36: Adds the passing-test list and runtime-balanced shard process that this change updates.
• Project516/java-web#14: Adds duration collection for passing-test runs, which is connected to the test-list workflow.
• Project516/java-web#47: Changes large-file handling and is connected to the additional OpenJDK tests noted in the PR context.

Merge Risk: Minimal · previous review a5be0

The added tests retain existing coverage and have timing data for CI sharding. No actionable merge-blocking risk was identified.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title states the main change: 49 more OpenJDK regression tests are added to the passing list. The raw summary confirms that passing.txt gains these tests. The summary says the additions include De…
Description check		The description states that 49 more OpenJDK regression tests are added to passing.txt, with durations in times.tsv, and it lists the test directories and the 37 tests that still fail. The raw summary …
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title states the main change: 49 more OpenJDK regression tests are added to the passing list. The raw summary confirms that passing.txt gains these tests. The summary says the additions include DeleteOnClose and PrefsSpiTest, which matches the description's directory breakdown.

Full details: Description check

Explanation

The description states that 49 more OpenJDK regression tests are added to passing.txt, with durations in times.tsv, and it lists the test directories and the 37 tests that still fail. The raw summary and objectives agree with this account, so the description relates directly to the changeset.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Simplify code

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks the test list at dawn
New file and channel cases hop along
JARs and ZIPs join the queue
Preferences get fresh checks too
The old entries make room to go
The rabbit stamps the list: ready to run!}

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: ba978303-7ce3-487b-a672-bbf171561b7f

Commits

Reviewing files that changed from the base of the PR and between 468c0f3 and a5be090.

Files ignored due to path filters: 1

• test/jtreg/times.tsv is excluded by !**/*.tsv

Files selected for processing: 1

• test/jtreg/passing.txt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 10

• GitHub Check: jtreg / run (1)
• GitHub Check: jtreg / run (2)
• GitHub Check: jtreg / run (7)
• GitHub Check: jtreg / run (8)
• GitHub Check: jtreg / run (3)
• GitHub Check: jtreg / run (4)
• GitHub Check: jtreg / run (5)
• GitHub Check: jtreg / run (6)
• GitHub Check: CodeRabbit
• GitHub Check: test

[project516-review-bot]

This PR adds 49 OpenJDK regression tests to the passing list (passing.txt) with their measured durations (times.tsv) after fixes for child processes, large files, and WatchService. The tests are inserted in sorted order in both files and the timing data appears consistent with the ~22 minutes total mentioned. Two long-running zipfs tests are correctly excluded. No defects found in the configuration changes.

---

_{review-bot, model nvidia/nemotron-3-ultra-550b-a55b:free, verdict approve}

[project516-review-bot]

This PR adds 49 OpenJDK regression tests to the passing list (passing.txt) and their measured durations to times.tsv for CI sharding. The tests now pass due to prior fixes for child processes, large files, and WatchService. Two long-running zipfs tests are correctly excluded due to the 600s timeout limit.

---

_{review-bot, model nvidia/nemotron-3-ultra-550b-a55b:free, verdict approve}